Bug 1192522
| Summary: | index heal doesn't continue crawl on self-heal failure | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | replicate | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.6.2 | CC: | bugs, rabhat |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-v3.6.3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-04 15:20:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1184460 | ||
REVIEW: http://review.gluster.org/9653 (cluster/afr: Crawl should continue on self-heal failures) posted (#1) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/9653 (cluster/afr: Crawl should continue on self-heal failures) posted (#2) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/9653 committed in release-3.6 by Raghavendra Bhat (raghavendra) ------ commit 21cf6ac8b852a04ded1e5399240292d0795035f6 Author: Pranith Kumar K <pkarampu> Date: Fri Feb 13 21:04:22 2015 +0530 cluster/afr: Crawl should continue on self-heal failures Problem: If self-heal fails on the last entry of readdir response list, index heal stops. Fix: Continue crawl even with partial failures. PS: Bug seems to exist only on 3.6.2, on master the code is fine after http://review.gluster.com/9485 Change-Id: Ie39b0d424297e3c95a05cbe72438dfd9a4d5696d BUG: 1192522 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9653 Reviewed-by: Krutika Dhananjay <kdhananj> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.3, please open a new bug report. glusterfs-v3.6.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2015-April/021669.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: This bug is found in code reading. Problem: If self-heal fails on the last entry of readdir response list, index heal doesn't stops. 'ret' value is not reset to zero after it is used, and the readdir-loop exists if 'ret' is non-zero, in afr_shd_index_sweep. Fix: Continue crawl even with partial failures. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: