Bug 1193481 (phpspec/php-diff) - Review Request: php-phpspec-php-diff - A library for generating differences between two hashable objects
Summary: Review Request: php-phpspec-php-diff - A library for generating differences b...
Status: CLOSED ERRATA
Alias: phpspec/php-diff
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: phpspec/phpspec
TreeView+ depends on / blocked
 
Reported: 2015-02-17 12:48 UTC by Remi Collet
Modified: 2015-03-11 16:40 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2015-03-05 12:36:14 UTC
shawn: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)
phpcompatinfo.log (3.55 KB, text/plain)
2015-02-22 02:48 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (7.09 KB, text/plain)
2015-02-22 02:48 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2015-02-17 12:48:40 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/b98e0bceed099b8b7d6f91270f3837a316253014/php/phpspec/php-phpspec-php-diff/php-phpspec-php-diff.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-phpspec-php-diff-1.0.2-1.remi.src.rpm
Description: 
A comprehensive library for generating differences between two hashable
objects (strings or arrays). Generated differences can be rendered in
all of the standard formats including:
 * Unified
 * Context
 * Inline HTML
 * Side by Side HTML

The logic behind the core of the diff engine (ie, the sequence matcher)
is primarily based on the Python difflib package. The reason for doing
so is primarily because of its high degree of accuracy.


Fedora Account System Username: remi

---

As usually, I plan to clean the EL-5 stuff after import.

Comment 1 Shawn Iwinski 2015-02-22 02:48:05 UTC
Created attachment 994210 [details]
phpcompatinfo.log

phpCompatInfo version 3.7.2

Comment 2 Shawn Iwinski 2015-02-22 02:48:48 UTC
Created attachment 994211 [details]
fedora-review.txt

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1193481
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 3 Shawn Iwinski 2015-02-22 02:50:15 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



No blockers.



===== APPROVED =====

Comment 4 Remi Collet 2015-02-22 07:32:44 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: php-phpspec-php-diff
Short Description: A library for generating differences between two hashable objects
Upstream URL: https://github.com/phpspec/php-diff
Owners: remi
Branches: f21 f22 epel7
InitialCC:

Comment 5 Patrick Uiterwijk 2015-02-24 09:49:15 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-02-24 13:31:10 UTC
php-phpspec-php-diff-1.0.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-phpspec-php-diff-1.0.2-1.fc21

Comment 7 Fedora Update System 2015-02-24 13:31:18 UTC
php-phpspec-php-diff-1.0.2-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-phpspec-php-diff-1.0.2-1.el7

Comment 8 Fedora Update System 2015-02-24 21:21:21 UTC
php-phpspec-php-diff-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 9 Fedora Update System 2015-03-05 12:36:14 UTC
php-phpspec-php-diff-1.0.2-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 10 Fedora Update System 2015-03-11 16:40:27 UTC
php-phpspec-php-diff-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.