Bug 1193482 - Implement setfsuid(), setfsgid() wrapper apis in libgfapi-python
Summary: Implement setfsuid(), setfsgid() wrapper apis in libgfapi-python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi-python
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Prashanth Pai
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-17 12:53 UTC by Humble Chirammal
Modified: 2016-04-22 06:17 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-22 06:17:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Humble Chirammal 2015-02-17 12:53:01 UTC
Description of problem:

Currently setuid() , setgid() apis are not available in libgfapi-python binding. This has to be available via python bindings.

Version-Release number of selected component (if applicable):

N/A

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

Missing setuid(), setgid() apis in python bindings of libgfapi.

Expected results:


These apis should be exposed for libgfapi-python consumers.

Additional info:

Comment 1 Lans Carstensen 2015-02-17 23:25:22 UTC
I haven't written unit tests for the additional functions, but the following patch works for me:

https://github.com/lcarstensen/libgfapi-python/compare/lcarstensen:master...setfs

Comment 2 Humble Chirammal 2015-02-18 07:24:33 UTC
(In reply to Lans Carstensen from comment #1)
> I haven't written unit tests for the additional functions, but the following
> patch works for me:
> 
> https://github.com/lcarstensen/libgfapi-python/compare/lcarstensen:master...
> setfs

Thanks!!
Can you please send this patch with unit test for the review @ review.gluster.org ? Please let us know/ping us If there is any blocker for this process. 

As a second option, we can work on the complete patch ( with unit test..etc) based on your patch. Please revert with your choice on this.

Comment 3 Prashanth Pai 2015-02-20 05:29:46 UTC
(In reply to Lans Carstensen from comment #1)
> I haven't written unit tests for the additional functions, but the following
> patch works for me:
> 
> https://github.com/lcarstensen/libgfapi-python/compare/lcarstensen:master...
> setfs

Thiago has a patch on review: http://review.gluster.org/9715

Comment 4 Prashanth Pai 2016-03-11 05:10:51 UTC
This patch has been merged.
http://review.gluster.org/#/c/9715/

This should fix the incorrect bug status.

Comment 5 Prashanth Pai 2016-04-22 06:17:28 UTC
When the change was sent and merged, there was no BUG id attached in the commit message. So in the "Bugs with incorrect status" report, this shows up as   

** ppai: No change posted, but bug 1193482 is in MODIFIED **

But the change has been posted by Thiago and already merged (http://review.gluster.org/#/c/9715/). The libgfapi-python never had an official release yet. Closing this with resolution NEXTRELEASE. Hope this is the right choice.

Historically, libgfapi-python project has not used bugzilla as the preferred tool to track tasks and progress. There's a public trello board here: https://trello.com/b/dKZYscO2/libgfapi-bindings


Note You need to log in before you can comment on or make changes to this bug.