Red Hat Bugzilla – Bug 1193685
Cannot change the docker upstream name for a repository that doesn't have a sync url
Last modified: 2016-07-27 05:13:28 EDT
Description of problem: When I try to set the repository upstream name for a repo that never had one, nothing happens. I see no error, etc. Version-Release number of selected component (if applicable): 6.1.0 How reproducible: Always Steps to Reproduce: 1. Create a docker repo with no upstream name and no sync url 2. Edit the docker repo's upstream name or url Actual results: Nothing happens. The upstream name is not changed and I don't see an error. Expected results: An error or success. Additional info:
Since this issue was entered in Red Hat Bugzilla, the release flag has been set to ? to ensure that it is properly evaluated for this release.
The current behavior is different than the bug description; however, the current behavior is also not correct. Current behavior, 1. user can create a docker repo without specifying url and upstream-name 2. if the user did not url and upstream-name during creation, they will receive an error, if they attempt edit the repository to add them. The reason being, the UI will only add 1 at a time; however, both are required, if at least one is provided. With docker v2, Satellite no longer support the ability to upload a docker image (now referred to as a manifest). As a result, in order to address this bugzilla, we are going to make url and upstream-name required on repository creation. If in the future, Satellite is able to support upload again, this can be revisited.
Created redmine issue http://projects.theforeman.org/issues/14111 from this bug
Upstream Katello PR: https://github.com/Katello/katello/pull/5859
Upstream bug component is Content Management
VERIFIED. @Sat6.2.0-Beta tfm-rubygem-katello-3.0.0.26-1.el7sat.noarch Tested both CLI/UI that upon docker repository creation an upstream name and Registry URL are always required. On updating docker repository the same check is applied. # hammer repository create --name empty --product "Custom Product" --organization-id 1 --content-type docker Could not create the repository: Validation failed: Repository URL or Upstream Name is empty. Both are required for syncing from the upstream. # hammer repository create --name empty --product "Custom Product" --organization-id 1 --content-type docker --url https://registry-1.docker.io/ Could not create the repository: Validation failed: Repository URL or Upstream Name is empty. Both are required for syncing from the upstream. # hammer repository create --name empty --product "Custom Product" --organization-id 1 --content-type docker --url https://registry-1.docker.io/ --docker-upstream-name o Could not create the repository: Validation failed: Docker upstream name must be a valid docker name # hammer repository create --name empty --product "Custom Product" --organization-id 1 --content-type docker --url https://registry-1.docker.io/ --docker-upstream-name busybox Repository created
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501