Spec URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration.spec SRPM URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration-0.0.8-1.fc21.src.rpm Description: Enables guests to have a registration capability, this is expecially useful on RHEL or SLES Fedora Account System Username: humaton
First of all; the package does not built. - state vagrant as build requirement as you need the vagrant macros Others: - missing upstream URL - wrong dependency on vagrant-libvirt - it does not depend on vagrant-libvirt at all - strange wording and typos - "Enables guests to have a registration capability, this is expecially useful on RHEL or SLES." could be "This Vagrant plugin enables guests to have a registration capability which is especially useful on RHEL or SLES." - README.md and CHANGELOG.md are not part of executable code so I would put them to %doc - misleading comment for check section "# Run the test suite" should be rather stating that we cannot run the test suite as it would require virtualization which is impossible in mock
Updated version Spec URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration.spec SRPM URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration-0.0.8-2.fc21.src.rpm
2 more things: - description should have 80 chars on one line, please make it two lines - license should be "GPLv2" [0] [0] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
Updated version Spec URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration.spec SRPM URL: https://fedorapeople.org/~humaton/rpms/vagrant-registration-0.0.8-3.fc21.src.rpm
Package builds, installs, works and the above mentioned problems have been fixed. Rpmlint found a minor issue: vagrant-registration.noarch: W: no-documentation vagrant-registration.src:97: W: macro-in-%changelog %doc 3 packages and 0 specfiles checked; 0 errors, 2 warnings. You can fix that before pushing (%doc -> %%doc). ==> APPROVED
New Package SCM Request ======================= Package Name: vagrant-registration Short Description: This Vagrant plugin enables guests to have a registration capability. Upstream URL: https://rubygems.org/gems/vagrant-registration Owners: humaton jstribny Branches: f21 f22 epel7 InitialCC: humaton jstribny
Git done (by process-git-requests).
@Tomáš: ping?
Can you please build this?