Bug 1194058 - Review Request: atomic - Tool for managing ProjectAtomic systems and containers
Summary: Review Request: atomic - Tool for managing ProjectAtomic systems and containers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-18 21:43 UTC by Lokesh Mandvekar
Modified: 2015-04-01 03:02 UTC (History)
4 users (show)

Fixed In Version: atomic-0-0.7.gita7ff4cb
Clone Of:
Environment:
Last Closed: 2015-04-01 03:02:08 UTC
Type: ---
Embargoed:
walters: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2015-02-18 21:43:31 UTC
Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec
SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.1.git6b82cb7.fc23.src.rpm

Upstream URL: https://github.com/projectatomic/atomic

Description:
%{summary}

The goal of Atomic is to provide a high level, coherent entrypoint to the
system, and fill in gaps.

For Docker, atomic can make it easier to interact with special kinds of
containers, such as super-privileged debugging tools and the like.

The atomic host subcommand wraps rpm-ostree, currently just providing a
friendlier name, but in the future Atomic may provide more unified
management.

Fedora Account System Username: lsm5

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8985986

Comment 1 Lokesh Mandvekar 2015-02-18 21:47:04 UTC
Need to install docs ... updating spec

Comment 2 Lokesh Mandvekar 2015-02-18 21:50:34 UTC
%changelog
* Wed Feb 18 2015 Lokesh Mandvekar <lsm5> - 0-0.2.git6b82cb7
- install docs

Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec
SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.2.git6b82cb7.fc23.src.rpm

Comment 3 Lokesh Mandvekar 2015-02-18 21:53:09 UTC
I'm hoping the package name 'atomic' isn't really confusing to people given:

$ yum search atomic
...
AtomicParsley-debuginfo.x86_64 : Debug information for package AtomicParsley
boost-atomic.i686 : Run-Time component of boost atomic library
boost-atomic.x86_64 : Run-Time component of boost atomic library
fedora-productimg-atomic.noarch : Installer branding and configuration for Fedora Atomic
katomic-debuginfo.x86_64 : Debug information for package katomic
libatomic.i686 : The GNU Atomic library
libatomic.x86_64 : The GNU Atomic library
libatomic-static.i686 : The GNU Atomic static library
libatomic-static.x86_64 : The GNU Atomic static library
libatomic_ops.i686 : Atomic memory update operations
libatomic_ops.x86_64 : Atomic memory update operations
libatomic_ops-debuginfo.x86_64 : Debug information for package libatomic_ops
libatomic_ops-devel.i686 : Development files for libatomic_ops
libatomic_ops-devel.x86_64 : Development files for libatomic_ops
libatomic_ops-static.i686 : Static library files for libatomic_ops
libatomic_ops-static.x86_64 : Static library files for libatomic_ops
rubygem-atomic.x86_64 : An atomic reference implementation for JRuby, Rubinius, and MRI
rubygem-atomic-debuginfo.x86_64 : Debug information for package rubygem-atomic
rubygem-atomic-doc.noarch : Documentation for rubygem-atomic
tuned-profiles-atomic.noarch : Additional tuned profiles targeted to Atomic
AtomicParsley.x86_64 : Command-line program to read and set MPEG-4 tags compatible with iPod/iTunes
ape.x86_64 : A tool for generating atomic pseudopotentials within a DFT framework
gpaw-setups.noarch : Atomic GPAW setups
katomic.x86_64 : An educational game built around molecular geometry
python-ase.noarch : Atomic Simulation Environment
texlive-tikzorbital.noarch : Atomic and molecular orbitals using TiKZ

Comment 4 Colin Walters 2015-02-18 22:00:02 UTC
- Does the description need to duplicate the summary?
- Can we upstream most of these build fixes?  I just submitted e.g. https://github.com/projectatomic/atomic/pull/19

Comment 5 Lokesh Mandvekar 2015-02-19 12:48:43 UTC
(In reply to Colin Walters from comment #4)
> - Does the description need to duplicate the summary?

It need not I guess. I deleted %{summary} from description.



Spec URL: https://github.com/lsm5/atomic-rpm/blob/master/atomic.spec
SRPM URL: https://github.com/lsm5/atomic-rpm/raw/master/SRPMS/atomic-0-0.3.gite4081c9.fc23.src.rpm

Comment 6 Lokesh Mandvekar 2015-02-20 15:25:52 UTC
Trouble with github urls sorry. Reverting to fedorapeople urls:

Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec
SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.3.gite4081c9.fc23.src.rpm

Comment 7 Colin Walters 2015-02-20 16:21:10 UTC
Ok, the latest fedora-review is giving me errors on RHEL7, so not pasting that.

However, we changed license upstream to LGPLv2+, can you update the spec file too?  See https://github.com/projectatomic/atomic/issues/21

With that change, LGTM.

Comment 8 Lokesh Mandvekar 2015-02-20 16:56:53 UTC
fedora-review seems to work fine on fedora rawhide though. but nvm, thanks for the review, here's the updates:

%changelog
* Fri Feb 20 2015 Lokesh Mandvekar <lsm5> - 0-0.4.gitf7f6fa8
- Resolves: rhbz#1194058 - approved version, ready for upload
- change license to LGPLv2+

Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec
SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.4.gitf7f6fa8.fc23.src.rpm


scm request follows

Comment 9 Lokesh Mandvekar 2015-02-20 17:00:03 UTC
New Package SCM Request
=======================
Package Name: atomic
Short Description: Tool for managing ProjectAtomic systems and containers
Upstream URL: https://github.com/projectatomic/atomic
Owners: lsm5 walters
Branches: f22 f21 f20
InitialCC:

Comment 10 Lokesh Mandvekar 2015-02-23 16:38:43 UTC
ping limb..

Comment 11 Gwyn Ciesla 2015-02-23 16:43:02 UTC
There's a problem with git branch creation at the moment, we're working on it.  Once we have it worked out I'll run the whole queue ASAP.

Comment 12 Patrick Uiterwijk 2015-02-24 10:00:32 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.