Bug 1194305 - [AFR-V2] - Do not count files which did not need index heal in the first place as successfully healed
Summary: [AFR-V2] - Do not count files which did not need index heal in the first plac...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1194306
TreeView+ depends on / blocked
 
Reported: 2015-02-19 14:17 UTC by Krutika Dhananjay
Modified: 2015-05-14 17:46 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of:
: 1194306 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:29:09 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2015-02-19 14:17:17 UTC
Description of problem:
When file modifications are happening while index heal is launched, index healer could pick up entries which appeared in indices/xattrop transiently during the course of the operations on the mount point, and do not really need any heal.
This will cause index healer to keep doing index-heal in a loop by believing that it did successfully heal some gfids even when it didn't.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-02-19 14:25:19 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-02-20 02:33:46 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2015-02-20 09:43:03 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2015-02-21 17:23:37 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#4) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Anand Avati 2015-02-24 14:38:30 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Anand Avati 2015-02-26 10:34:17 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#6) for review on master by Krutika Dhananjay (kdhananj)

Comment 7 Anand Avati 2015-02-27 08:31:23 UTC
REVIEW: http://review.gluster.org/9713 (cluster/afr: Do not increment healed_count if no healing was performed) posted (#7) for review on master by Krutika Dhananjay (kdhananj)

Comment 8 Anand Avati 2015-03-05 00:38:00 UTC
COMMIT: http://review.gluster.org/9713 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 4a8384fe76aeef652554c48df737d3178eb0160c
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Feb 19 19:35:17 2015 +0530

    cluster/afr: Do not increment healed_count if no healing was performed
    
    PROBLEM:
    When file modifications are happening while index heal is launched,
    index healer could pick up entries which appeared in indices/xattrop
    transiently during the course of the operations on the mount point, and
    do not really need any heal. This will cause index healer to keep doing
    index-heal in a loop as long as it finds this entry, by believing that
    it did successfully heal some gfids even when it didn't.
    
    FIX:
    afr_selfheal() now returns a 1 to indicate that it did not (need to)
    heal a given gfid. afr_shd_selfheal() will not increment healed_count
    whenever afr_selfheal() returns a 1.
    
    Change-Id: I0d97e11392a032a852e8c6508f691300ef0e5b98
    BUG: 1194305
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/9713
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Ravishankar N <ravishankar>
    Tested-by: Gluster Build System <jenkins.com>

Comment 9 Niels de Vos 2015-05-14 17:29:09 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:35:51 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:38:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:46:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.