Spec URL: https://ppisar.fedorapeople.org/perl-Module-Metadata-Changes/perl-Module-Metadata-Changes.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Metadata-Changes/perl-Module-Metadata-Changes-2.05-1.fc23.src.rpm Description: Module::Metadata::Changes is a pure Perl module. It allows you to convert old-style Changes/CHANGES files, and to read and write Changelog.ini files. Fedora Account System Username: ppisar
Note: All the patched files are read-only. I assume the patching could fail, even though it currently doesn't. Perhaps making them writable before patching would be a good idea. Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide %{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the patch. Consider bumping the minimum required version of EU::MM to 6.76 and using NO_PACKLIST to simplify the SPEC. The convert.t test doesn't actually convert anything. Maybe you could enhance it a bit? However, that's beyond the scope of this review.
(In reply to Petr Šabata from comment #1) > Note: All the patched files are read-only. I assume the patching could > fail, even though it currently doesn't. Perhaps making them writable before > patching would be a good idea. > I added this write permissions to the spec file. Updated package is on the same address. > Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide > %{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the > patch. > This was a bug in guidelines and has been already corrected <https://fedoraproject.org/w/index.php?title=Packaging%3AWeb_Assets&action=historysubmit&diff=404471&oldid=350293>. The name with the dot is correct one. > Consider bumping the minimum required version of EU::MM to 6.76 and using > NO_PACKLIST to simplify the SPEC. > > The convert.t test doesn't actually convert anything. Maybe you could > enhance it a bit? However, that's beyond the scope of this review. I'm not much interested in this.
(In reply to Petr Pisar from comment #2) > (In reply to Petr Šabata from comment #1) > > Note: All the patched files are read-only. I assume the patching could > > fail, even though it currently doesn't. Perhaps making them writable before > > patching would be a good idea. > > > I added this write permissions to the spec file. Updated package is on the > same address. Ack. > > Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide > > %{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the > > patch. > > > This was a bug in guidelines and has been already corrected > <https://fedoraproject.org/w/index. > php?title=Packaging%3AWeb_Assets&action=historysubmit&diff=404471&oldid=35029 > 3>. The name with the dot is correct one. Fair enough. > > Consider bumping the minimum required version of EU::MM to 6.76 and using > > NO_PACKLIST to simplify the SPEC. > > > > The convert.t test doesn't actually convert anything. Maybe you could > > enhance it a bit? However, that's beyond the scope of this review. > > I'm not much interested in this. Okay then. Approving.
New Package SCM Request ======================= Package Name: perl-Module-Metadata-Changes Short Description: Manage a module's machine-readable Changes/CHANGES file Upstream URL: http://search.cpan.org/dist/Module-Metadata-Changes/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.