Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1194641 - User shouldn't be allowed to create BMC interface without mac
Summary: User shouldn't be allowed to create BMC interface without mac
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: Unspecified
Assignee: Marek Hulan
QA Contact: Sachin Ghai
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On: 1191913
Blocks: 1193987
TreeView+ depends on / blocked
 
Reported: 2015-02-20 12:45 UTC by Sachin Ghai
Modified: 2017-02-23 20:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-12 05:26:38 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
BMC interface is configured without defining mac (38.16 KB, image/png)
2015-05-08 12:11 UTC, Sachin Ghai 		no flags Details
I can see BMC tab and power-cycle options on right (43.31 KB, image/png)
2015-05-08 12:12 UTC, Sachin Ghai 		no flags Details
valiadation error while configurating managed BMC without mac (25.82 KB, image/png)
2015-05-11 12:15 UTC, Sachin Ghai 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 9497 0 None None None 2016-04-22 16:38:28 UTC
Red Hat Product Errata RHSA-2015:1592 0 normal SHIPPED_LIVE Important: Red Hat Satellite 6.1.1 on RHEL 6 2015-08-12 09:04:35 UTC

Description Sachin Ghai 2015-02-20 12:45:05 UTC 
Description of problem:
I tried to create BMC interface and didn't specify the mac. I marked it as managed too. I think UI should validate the form. Form was submitted successfully. I believe BMC interfaces should have mac as physical network interfaces.


Version-Release number of selected component (if applicable):
sat6.1 beta snap3
Satellite-6.1.0-RHEL-6-20150217.0

How reproducible:
always

Steps to Reproduce:
1. Add BMC interface without specifying mac
2.
3.

Actual results:
No error on UI

Expected results:
UI should raise validation error.

Additional info:
Comment 1 Marek Hulan 2015-02-22 09:51:30 UTC 
Created redmine issue http://projects.theforeman.org/issues/9497 from this bug
Comment 2 Bryan Kearney 2015-02-26 15:05:24 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/9497 has been closed
-------------
Marek Hulán
Applied in changeset commit:6a2fce1fa6a80865bb8292e76a8bd285e714a5c8.
Comment 5 Bryan Kearney 2015-03-03 15:05:40 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/9497 has been closed
-------------
Marek Hulán
Applied in changeset commit:6a2fce1fa6a80865bb8292e76a8bd285e714a5c8.
Comment 8 Sachin Ghai 2015-03-17 11:38:26 UTC 
Verified with: 

sat6.1 beta snap6 compose2 (Satellite-6.1.0-RHEL-6-20150311.1).


I didn't see any change after fix. If I didn't specify mac of BMC interface then nothig happens on UI, new host form was submitted and BMC doesn't configured. so it is still failing silently. 

I was expecting an error message like 'can't be blank' if I don't specify mac. Moving back to assigned.
Comment 9 Marek Hulan 2015-03-19 14:55:33 UTC 
Moving back to ON_QA as it's blocker by a separate issue tracked as https://bugzilla.redhat.com/show_bug.cgi?id=1191913
Comment 10 Sachin Ghai 2015-05-08 12:09:22 UTC 
Found different behaviour with sat6.1 GA snap3.

I really not sure what should be the intended behaviour here.

When I filed this bz then I defined the BMC interface without mac and provisioned the host. Host was provisioned successfully. But later when I checked the BMC interface then it was not configured. It means that BMC configuration fails silently without throwing any error on UI. This is very annoying situation where you get to know something is failing at the end of workflow instead of beginning.

Now, if I didn't specify the mac for BMC interface, UI actually configure it. Is it expected ?  If that's the case then I'm assuming mac is not a mandatory option for BMC configuration ?
Comment 11 Sachin Ghai 2015-05-08 12:11:48 UTC 
Created attachment 1023461 [details]
BMC interface is configured without defining mac
Comment 12 Sachin Ghai 2015-05-08 12:12:33 UTC 
Created attachment 1023462 [details]
I can see BMC tab and power-cycle options on right
Comment 13 Marek Hulan 2015-05-11 11:29:47 UTC 
The MAC for BMC is only required if the BMC is managed so it can create DHCP reservation (and I see validation error). If you choose to have BMC unmanaged then no MAC is needed and BMC is saved. If host has BMC you can see the BMC tab displaying data from BMC (no MAC is needed for this) so I think the behaviour is correct.
Comment 14 Sachin Ghai 2015-05-11 12:14:09 UTC 
@Marek.. Thanks for reply.

I just tried configuring Managed BMC interface without mac and this time I got validation error: mac can't be blank" thanks.
Comment 15 Sachin Ghai 2015-05-11 12:15:19 UTC 
Created attachment 1024201 [details]
valiadation error while configurating managed BMC without mac
Comment 16 Marek Hulan 2015-05-11 12:20:34 UTC 
Thanks for retesting.
Comment 17 Sachin Ghai 2015-05-11 12:22:26 UTC 
Verified with sat6.1 GA snap3.

Based on comments 10-15. Moving this to verified. thanks for fixing the issue.
Comment 18 Bryan Kearney 2015-08-11 13:18:28 UTC 
This bug is slated to be released with Satellite 6.1.
Comment 19 errata-xmlrpc 2015-08-12 05:26:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592
Note You need to log in before you can comment on or make changes to this bug.