Bug 1194652 - Missing which and file requirements in dkms package spec file
Summary: Missing which and file requirements in dkms package spec file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dkms
Version: 20
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Simone Caronni
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-20 13:05 UTC by Richard Wall
Modified: 2015-03-15 01:01 UTC (History)
4 users (show)

Fixed In Version: dkms-2.2.0.3-30.el5
Clone Of:
Environment:
Last Closed: 2015-03-09 08:30:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Richard Wall 2015-02-20 13:05:09 UTC
Description of problem:

When I attempt to install zfsonlinux, I see the following warnings when dkms tools attempt to compile 

```
[root.132.15] out:   Installing : spl-dkms-0.6.3-10_g59edeca.fc20.noarch 
[root.132.15] out: Loading new spl-0.6.3 DKMS files...
[root.132.15] out: /usr/lib/dkms/common.postinst: line 123: which: command not found
[root.132.15] out: Building for 3.18.7-100.fc20.x86_64
[root.132.15] out: Building initial module for 3.18.7-100.fc20.x86_64
[root.132.15] out: /var/lib/dkms/spl/0.6.3/build/configure: line 6355: /usr/bin/file: No such file or directory
```

See:
 * http://linux.dell.com/cgi-bin/cgit.cgi/dkms.git/tree/dkms_common.postinst

It turns out that this Fedora 20 AMI (Fedora-x86_64-20-20140407-sda) does not include the `file` or `which` packages.

I propose that those packages should be added as dkms package requirements

Version-Release number of selected component (if applicable):

```
[root@ip-172-31-46-240 ~]# yum info dkms
Installed Packages
Name        : dkms
Arch        : noarch
Version     : 2.2.0.3
Release     : 28.git.7c3e7c5.fc20
Size        : 221 k
Repo        : installed
From repo   : updates
Summary     : Dynamic Kernel Module Support Framework
URL         : http://linux.dell.com/dkms
Licence     : GPLv2+
Description : This package contains the framework for the Dynamic Kernel Module Support (DKMS)
            : method for installing module RPMS as originally developed by Dell.


```

How reproducible:


Steps to Reproduce:
1. yum install -y https://s3.amazonaws.com/archive.zfsonlinux.org/fedora/zfs-release$(rpm -E %dist).noarch.rpm
2. yum install -y https://storage.googleapis.com/archive.clusterhq.com/fedora/clusterhq-release$(rpm -E %dist).noarch.rpm (repo may have a newer zfs package)
3. yum install zfs

Actual results:
 * See warning messages above.


Expected results:
 * No warnings on stdout.


Additional info:

Comment 1 Fedora Update System 2015-02-25 07:55:35 UTC
dkms-2.2.0.3-29.git.7c3e7c5.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-29.git.7c3e7c5.fc20

Comment 2 Fedora Update System 2015-02-25 07:55:47 UTC
dkms-2.2.0.3-29.git.7c3e7c5.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-29.git.7c3e7c5.fc21

Comment 3 Fedora Update System 2015-02-25 07:56:03 UTC
dkms-2.2.0.3-29.git.7c3e7c5.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-29.git.7c3e7c5.el7

Comment 4 Fedora Update System 2015-02-25 07:56:19 UTC
dkms-2.2.0.3-29.git.7c3e7c5.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-29.git.7c3e7c5.el6

Comment 5 Fedora Update System 2015-02-25 07:56:36 UTC
dkms-2.2.0.3-29.git.7c3e7c5.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-29.git.7c3e7c5.fc22

Comment 6 Richard Wall 2015-02-25 10:05:49 UTC
Hi, I reviewed the changes, but it looks (to me) like you only added the `which` and `file` requirements to the `el5` branch:
 * http://pkgs.fedoraproject.org/cgit/dkms.git/commit/?h=el5&id=386f365f92720de84bd4b09509b3bf4e3a4dcf14

The commit messages to other branches say "Add which and file requirements (#1194652) and license macro" but the new requirements do not appear to be listed:
 *  http://pkgs.fedoraproject.org/cgit/dkms.git/commit/?h=f20&id=e2d28226cdb923cfcabd58b55ae02d7ddcc98821


And when I check the package from koji, the requirements do not include `which` or `file`:

```
[~/tmp]$ rpm --query --requires --package dkms-2.2.0.3-29.git.7c3e7c5.fc20.noarch.rpm
/bin/bash
/bin/sh
/bin/sh
/bin/sh
/bin/sh
config(dkms) = 2.2.0.3-29.git.7c3e7c5.fc20
coreutils
cpio
findutils
gawk
gcc
grep
gzip
kernel-devel
kmod
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
sed
systemd
systemd
systemd
tar
rpmlib(PayloadIsXz) <= 5.2-1
```

Comment 7 Simone Caronni 2015-02-25 13:20:19 UTC
Oh shit, I made some confusion with the branches, as for el5 I had to come back to an old revision in GIT.

I will apply the change and re-push the update.

Thanks!

Comment 8 Fedora Update System 2015-02-25 13:41:18 UTC
dkms-2.2.0.3-30.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/dkms-2.2.0.3-30.el5

Comment 9 Simone Caronni 2015-02-25 13:43:34 UTC
Updated the Bodhi updates:

dkms-2.2.0.3-30.git.7c3e7c5.fc22
dkms-2.2.0.3-30.git.7c3e7c5.fc21
dkms-2.2.0.3-30.git.7c3e7c5.fc20
dkms-2.2.0.3-30.git.7c3e7c5.el7
dkms-2.2.0.3-30.git.7c3e7c5.el6
dkms-2.2.0.3-30.el5

Comment 10 Fedora Update System 2015-02-25 15:15:47 UTC
Package dkms-2.2.0.3-30.git.7c3e7c5.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dkms-2.2.0.3-30.git.7c3e7c5.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2567/dkms-2.2.0.3-30.git.7c3e7c5.fc22
then log in and leave karma (feedback).

Comment 11 Richard Wall 2015-02-26 10:46:40 UTC
I tested the f20 package and added karma:
 * https://admin.fedoraproject.org/updates/FEDORA-2015-2619/dkms-2.2.0.3-30.git.7c3e7c5.fc20

Hope that helps.

Comment 12 Fedora Update System 2015-03-09 08:30:46 UTC
dkms-2.2.0.3-30.git.7c3e7c5.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-03-14 09:14:51 UTC
dkms-2.2.0.3-30.git.7c3e7c5.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-03-14 09:22:47 UTC
dkms-2.2.0.3-30.git.7c3e7c5.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2015-03-15 01:00:00 UTC
dkms-2.2.0.3-30.git.7c3e7c5.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-03-15 01:00:40 UTC
dkms-2.2.0.3-30.git.7c3e7c5.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-03-15 01:01:08 UTC
dkms-2.2.0.3-30.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.