Bug 1194690

Description of problem:
CLI cannot connect to the JON server when it is configured to use agent-server communication over sslsocket.

The solution provided here: https://access.redhat.com/solutions/793503 
does NOT work for JON3.3.0

/jon/cli/bin/rhq-cli.sh -u rhqadmin -p rhqadmin -s 127.0.0.1 -t 55555 --transport sslsocket
Invalid transport [sslsocket], should be either http or https

Version-Release number of selected component (if applicable):
3.3.0

How reproducible:
Always

Steps to Reproduce:
1. Configure JBoss ON Server to use sslsocket and designate a port
rhq.communications.connector.transport=sslsocket
  rhq.communications.connector.bind-port=55555    
2. Try to connect via rhq-cli
rhq-cli.sh -u rhqadmin -p rhqadmin -s 127.0.0.1 -t 55555 --transport sslsocket


Actual results:
Error message:
Invalid transport [sslsocket], should be either http or https

Expected results:
Connect to the JBoss ON server as it did in version 3.2

Additional info:
unconnected$ login --help
Usage: login username password [host]|[host port]|[host port <http>|<https>]
Log into a server with the specified username and password. The server host name and port may optionally be specified. The host name defaults to localhost and the port to 7080. You may also specify the transport to use when communicating with the server; it must be one of 'servlet' or 'sslservlet'.

So the help + error messages says you need to use <http>|<https> .... and the sentence below says you need to use 'servlet' or 'sslservlet'

Then, the code:

RHQ/​ modules/​ enterprise/​ remoting/​ cli/​ src/​ main/​ java/​ org/​ rhq/​ enterprise/​ client/​ commands/​ LoginCommand.java

083         if (args.length > argIndex) {
084             transport = args[argIndex];
085             if (!"http".equals(transport) || !"https".equals(transport)) {
086                 printWriter.println("Invalid transport [" + transport + "], should be either http or https");
087                 return true;
088             }

So regardless what you specify:  http, https, servlet, sslservlet or pigeons.... nothing gets accepted.

I did follow the rest of the code, and socket/sslsocket is not support but that is no real issue here. The agents can still use sockets to communicate; it's just that the CLI must have access to the http(s) port and uses (ssl)servlet.