Bug 1194926 - Review Request: nodejs-set-immediate-shim - Simple setImmediate shim
Summary: Review Request: nodejs-set-immediate-shim - Simple setImmediate shim
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zuzana Svetlikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews 1194931
TreeView+ depends on / blocked
 
Reported: 2015-02-20 23:16 UTC by Piotr Popieluch
Modified: 2015-06-21 00:30 UTC (History)
2 users (show)

Fixed In Version: nodejs-set-immediate-shim-1.0.1-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-05 23:57:12 UTC
Type: ---
Embargoed:
zsvetlik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2015-02-20 23:16:21 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-set-immediate-shim.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-set-immediate-shim-1.0.0-1.fc21.src.rpm
Description: Simple setImmediate shim
Fedora Account System Username: piotrp

Comment 1 Piotr Popieluch 2015-03-08 13:50:55 UTC
Updates Source0 to comply with github guidelines

Spec URL: https://piotrp.fedorapeople.org/nodejs-set-immediate-shim.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-set-immediate-shim-1.0.0-2.fc21.src.rpm

Comment 2 Zuzana Svetlikova 2015-05-20 14:04:31 UTC
APPROVED, looks fine, except the latest version is 1.0.1



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 2 files have unknown license. Detailed
     output of licensecheck in /home/kasicka/fedrev/1194926-nodejs-set-
     immediate-shim/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-set-immediate-shim-1.0.0-2.fc21.noarch.rpm
          nodejs-set-immediate-shim-1.0.0-2.fc21.src.rpm
nodejs-set-immediate-shim.noarch: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate-shim.noarch: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate-shim.noarch: W: only-non-binary-in-usr-lib
nodejs-set-immediate-shim.src: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate-shim.src: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness
2 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
nodejs-set-immediate-shim.noarch: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate-shim.noarch: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate-shim.noarch: W: invalid-url URL: https://github.com/sindresorhus/set-immediate-shim <urlopen error [Errno -3] Temporary failure in name resolution>
nodejs-set-immediate-shim.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 4 warnings.



Requires
--------
nodejs-set-immediate-shim (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-set-immediate-shim:
    nodejs-set-immediate-shim
    npm(set-immediate-shim)



Source checksums
----------------
https://github.com/sindresorhus/set-immediate-shim/archive/29ac611e181046f2cf8b61ed5d038c64733a1cbc/set-immediate-shim-29ac611e181046f2cf8b61ed5d038c64733a1cbc.tar.gz :
  CHECKSUM(SHA256) this package     : 043fba3935ec0ed30bba4d78bd5fba19cd022a57e8ac65b6642bf16b8660ed56
  CHECKSUM(SHA256) upstream package : 043fba3935ec0ed30bba4d78bd5fba19cd022a57e8ac65b6642bf16b8660ed56


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1194926
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Piotr Popieluch 2015-05-22 17:20:57 UTC
Thank you, will update to latest version before pushing.

New Package SCM Request
=======================
Package Name: nodejs-set-immediate-shim
Short Description: Simple setImmediate shim
Upstream URL: https://github.com/sindresorhus/set-immediate-shim
Owners: piotrp
Branches: f20 f21 f22 el6 epel7

Comment 4 Gwyn Ciesla 2015-05-24 20:32:06 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2015-05-25 09:32:07 UTC
nodejs-set-immediate-shim-1.0.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-set-immediate-shim-1.0.1-1.fc22

Comment 6 Fedora Update System 2015-05-25 09:33:57 UTC
nodejs-set-immediate-shim-1.0.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-set-immediate-shim-1.0.1-1.fc20

Comment 7 Fedora Update System 2015-05-27 16:13:45 UTC
nodejs-set-immediate-shim-1.0.1-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 8 Zuzana Svetlikova 2015-06-05 21:43:56 UTC
Can you please build this for f21 too?

Comment 9 Fedora Update System 2015-06-05 23:57:12 UTC
nodejs-set-immediate-shim-1.0.1-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 10 Fedora Update System 2015-06-06 00:11:54 UTC
nodejs-set-immediate-shim-1.0.1-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 11 Fedora Update System 2015-06-06 21:35:06 UTC
nodejs-set-immediate-shim-1.0.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-set-immediate-shim-1.0.1-1.fc21

Comment 12 Piotr Popieluch 2015-06-06 21:37:29 UTC
thanks for pointing out. don't know how i could miss this.

Comment 13 Fedora Update System 2015-06-21 00:30:36 UTC
nodejs-set-immediate-shim-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.