Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/1f7c4cfdcdc2f5310836629d2cef2e11bd996aab/php/php-kolab-net-ldap3/php-kolab-net-ldap3.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-kolab-net-ldap3-1.0.2-1.remi.src.rpm Description: A successor of the PEAR:Net_LDAP2 module providing advanced functionality for accessing LDAP directories. Fedora Account System Username: remi -- Optional dep of roundecubemail As usually, I plan to clean EL-5 stuff after import.
@limb and this one too ;)
Good: - rpmlint checks return: Nothing. - package meets naming guidelines - package meets packaging guidelines ! license ( Spec says GPLv3+, composer.json says GPLv3) - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Looks like just the license tag unless GPLv3+ is listed elsewhere.
Probably "composer.json" is not as much as strict as it should be ;) From the file header: | Licensed under the GNU General Public License version 3 or | | any later version with exceptions for plugins. |
Upstream bug for reference: https://issues.kolab.org/show_bug.cgi?id=4695
Add comment about license and upstream bug (no release bump): https://github.com/remicollet/remirepo/commit/e953f80133da942d4203ce9999b7b1db00cfee39 Spec: https://raw.githubusercontent.com/remicollet/remirepo/e953f80133da942d4203ce9999b7b1db00cfee39/php/php-kolab-net-ldap3/php-kolab-net-ldap3.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-kolab-net-ldap3-1.0.2-1.remi.src.rpm
Add upstream Patch for License clarification: https://github.com/remicollet/remirepo/commit/4546f5f844adee0f8b35f380743e666f94d0df1a Spec: https://raw.githubusercontent.com/remicollet/remirepo/4546f5f844adee0f8b35f380743e666f94d0df1a/php/php-kolab-net-ldap3/php-kolab-net-ldap3.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-kolab-net-ldap3-1.0.2-2.remi.src.rpm
Looks good, thanks!
Thanks for the review! New Package SCM Request ======================= Package Name: php-kolab-net-ldap3 Short Description: Advanced functionality for accessing LDAP directories Upstream URL: http://git.kolab.org/pear/Net_LDAP3/ Owners: remi Branches: f20 f21 f22 el6 epel7 InitialCC:
Git done (by process-git-requests).
php-kolab-net-ldap3-1.0.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.fc20
php-kolab-net-ldap3-1.0.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.el6
php-kolab-net-ldap3-1.0.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.fc21
php-kolab-net-ldap3-1.0.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.el7
php-kolab-net-ldap3-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
php-kolab-net-ldap3-1.0.2-2.fc20 has been pushed to the Fedora 20 stable repository.
php-kolab-net-ldap3-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository.
php-kolab-net-ldap3-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
php-kolab-net-ldap3-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.