Bug 1195058 (kolab/net_ldap3) - Review Request: php-kolab-net-ldap3 - Advanced functionality for accessing LDAP directories
Summary: Review Request: php-kolab-net-ldap3 - Advanced functionality for accessing LD...
Keywords:
Status: CLOSED ERRATA
Alias: kolab/net_ldap3
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: Net_LDAP2
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-22 16:08 UTC by Remi Collet
Modified: 2015-03-11 16:40 UTC (History)
2 users (show)

Fixed In Version: php-kolab-net-ldap3-1.0.2-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 12:32:02 UTC
gwync: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Remi Collet 2015-02-22 16:08:21 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/1f7c4cfdcdc2f5310836629d2cef2e11bd996aab/php/php-kolab-net-ldap3/php-kolab-net-ldap3.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-kolab-net-ldap3-1.0.2-1.remi.src.rpm
Description: 
A successor of the PEAR:Net_LDAP2 module providing advanced functionality
for accessing LDAP directories.

Fedora Account System Username: remi

-- 

Optional dep of roundecubemail

As usually, I plan to clean EL-5 stuff after import.

Comment 1 Remi Collet 2015-02-22 16:09:36 UTC
@limb and this one too ;)

Comment 2 Gwyn Ciesla 2015-02-23 20:37:02 UTC
Good:

- rpmlint checks return:

Nothing.

- package meets naming guidelines
- package meets packaging guidelines
! license ( Spec says GPLv3+, composer.json says GPLv3)
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Looks like just the license tag unless GPLv3+ is listed elsewhere.

Comment 3 Remi Collet 2015-02-24 07:15:52 UTC
Probably "composer.json" is not as much as strict as it should be ;)

From the file header:
 | Licensed under the GNU General Public License version 3 or            |
 | any later version with exceptions for plugins.                        |

Comment 4 Remi Collet 2015-02-24 08:29:22 UTC
Upstream bug for reference: https://issues.kolab.org/show_bug.cgi?id=4695

Comment 7 Gwyn Ciesla 2015-02-24 13:52:35 UTC
Looks good, thanks!

Comment 8 Remi Collet 2015-02-24 13:57:54 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: php-kolab-net-ldap3
Short Description: Advanced functionality for accessing LDAP directories 
Upstream URL: http://git.kolab.org/pear/Net_LDAP3/
Owners: remi
Branches: f20 f21 f22 el6 epel7
InitialCC:

Comment 9 Gwyn Ciesla 2015-02-24 14:01:13 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2015-02-24 15:56:01 UTC
php-kolab-net-ldap3-1.0.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.fc20

Comment 11 Fedora Update System 2015-02-24 15:56:06 UTC
php-kolab-net-ldap3-1.0.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.el6

Comment 12 Fedora Update System 2015-02-24 15:56:12 UTC
php-kolab-net-ldap3-1.0.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.fc21

Comment 13 Fedora Update System 2015-02-24 15:56:20 UTC
php-kolab-net-ldap3-1.0.2-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-kolab-net-ldap3-1.0.2-2.el7

Comment 14 Fedora Update System 2015-02-24 21:21:13 UTC
php-kolab-net-ldap3-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 15 Fedora Update System 2015-03-05 12:32:02 UTC
php-kolab-net-ldap3-1.0.2-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 16 Fedora Update System 2015-03-05 12:37:46 UTC
php-kolab-net-ldap3-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 17 Fedora Update System 2015-03-11 16:40:14 UTC
php-kolab-net-ldap3-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 18 Fedora Update System 2015-03-11 16:40:20 UTC
php-kolab-net-ldap3-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.