Bug 1195071 - enable modbus-usb support
Summary: enable modbus-usb support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: apcupsd
Version: epel7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-22 17:48 UTC by Nerijus Baliūnas
Modified: 2017-04-13 18:50 UTC (History)
4 users (show)

Fixed In Version: apcupsd-3.14.13-4.fc23 apcupsd-3.14.13-2.fc22 apcupsd-3.14.14-4.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-13 18:50:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nerijus Baliūnas 2015-02-22 17:48:39 UTC
One of the 3.14.13 release highlights is MODBUS USB support. Also there is no longer --enable-powerflute configure flag. libusb-devel is needed for modbus-usb support. The spec diff:

--- apcupsd.spec.orig   2015-02-03 17:33:27.000000000 +0200
+++ apcupsd.spec        2015-02-22 19:41:00.375011675 +0200
@@ -21,7 +21,7 @@
 BuildRoot:    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 BuildRequires: glibc-devel >= 2.3, gd-devel > 2.0
-BuildRequires: net-snmp-devel, tcp_wrappers-devel
+BuildRequires: net-snmp-devel, tcp_wrappers-devel, libusb-devel
 BuildRequires: gtk2-devel, gnome-vfs2-devel, desktop-file-utils
 Requires:      /bin/mail
 Requires(post): systemd-units
@@ -85,7 +85,7 @@
         --enable-net-snmp \
         --enable-snmp \
         --enable-usb \
-        --enable-powerflute \
+        --enable-modbus-usb \
         --enable-nls \
         --enable-gapcmon \
         --enable-pcnet \

Comment 1 Nerijus Baliūnas 2015-03-13 22:53:48 UTC
When building package, I get:
configure: WARNING: unrecognized options: --disable-dependency-tracking, --enable-pthreads, --enable-nls

So --enable-pthreads and --enable-nls should be removed too.

Comment 2 Yu Watanabe 2015-05-01 09:19:27 UTC
Are there any plan to include this patch to the package?
I would like to use modbus over usb as soon as possible.

Comment 3 Fedora Update System 2015-11-23 14:26:34 UTC
apcupsd-3.14.13-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-482e23724e

Comment 4 Fedora Update System 2015-11-23 14:26:36 UTC
apcupsd-3.14.13-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d09886fa52

Comment 5 Fedora Update System 2015-11-23 14:26:50 UTC
apcupsd-3.14.13-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-e8eded3b5a

Comment 6 Nerijus Baliūnas 2015-11-23 14:40:11 UTC
Thanks for the update! It would be nice to release update for epel too.

Comment 7 Fedora Update System 2015-11-24 00:23:44 UTC
apcupsd-3.14.13-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update apcupsd'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-e8eded3b5a

Comment 8 Fedora Update System 2015-11-24 00:54:23 UTC
apcupsd-3.14.13-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update apcupsd'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-482e23724e

Comment 9 Fedora Update System 2015-11-24 02:23:03 UTC
apcupsd-3.14.13-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update apcupsd'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d09886fa52

Comment 10 Fedora Update System 2015-11-26 20:56:23 UTC
apcupsd-3.14.13-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-02-17 04:23:54 UTC
apcupsd-3.14.13-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Nerijus Baliūnas 2017-03-24 09:30:19 UTC
Is it possible to release updated apcupsd packages with modbus support for epel7 too?

Comment 13 Jason Tibbitts 2017-03-24 17:45:22 UTC
It would have been nicer to file a new bug asking for the version in EPEL7 to be updated…

In any case, I suppose we could just keep EPEL7 and Fedora in sync, which from a package maintenance standpoint is far preferable to me.  I don't think there are any breaking changes between 3.14.12 and 3.14.14, but I'm not 100% certain.

I could just let it soak in testing for a while; I doubt that would upset anyone.

Eric, what do you think?

Comment 14 Eric Sandeen 2017-03-24 18:09:57 UTC
I have no concrete reason to object.  Does this require libmodbus?

Comment 15 Jason Tibbitts 2017-03-24 18:17:02 UTC
libmodbus isn't in the set of build dependencies, just libusb-devel.

Comment 16 Jason Tibbitts 2017-03-24 23:23:12 UTC
I added a couple of spec bits so that the current spec builds on both EPEL7 and Fedora, and pulled that down from Rawhide to EL7 and did a build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18579443

I can push it to updates and step on the existing update that's there (which I didn't even know about until the ticket was reassigned) but now I have to worry about regressing that fix.

Comment 17 Fedora Update System 2017-03-27 22:34:27 UTC
apcupsd-3.14.14-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4b5002cd01

Comment 18 Fedora Update System 2017-03-29 03:18:44 UTC
apcupsd-3.14.14-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4b5002cd01

Comment 19 Fedora Update System 2017-04-13 18:50:01 UTC
apcupsd-3.14.14-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.