I would like to rename package 'lmiwbem' to 'python-lmiwbem'. Spec URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/lmiwbem.spec SRPM URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem-0.6.0-2.fc22.src.rpm Description: python-lmiwbem is a Python library, which performs CIM operations using CIM-XML protocol. The library tries to mimic PyWBEM. Fedora Account System Username: phatina
My findings: * there's a new version of lmiwbem available (0.7.0) why not bundle it? * moreover lmiwbem-0.6.0-2.fc22 already exists in koji * lmiwbem.spec should be python-lmiwbem.spec - fedora-review tool refused to run due to this * according to [1], Obsoletes should include a release higher than the last available release of the old package - If I understand this correctly, it should be: Obsoletes: lmiwbem <= 0.6.0-3 * again according to [1], Provides should be listed twice - once with %{?_isa} macro and once without: Provides: lmiwbem = %{version}-%{release} Provides: lmiwbem%{?_isa} = %{version}-%{release} rpmlint findings: * python-lmiwbem.spec: W: invalid-url Source0: https://github.com/phatina/lmiwbem/releases/download/python-lmiwbem-0.6.0/python-lmiwbem-0.6.0.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Spec URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem.spec SRPM URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem-0.7.0-1.fc23.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9049374 (In reply to Michal Minar from comment #1) > My findings: > * there's a new version of lmiwbem available (0.7.0) why not bundle it? OK, done. > * moreover lmiwbem-0.6.0-2.fc22 already exists in koji > * lmiwbem.spec should be python-lmiwbem.spec > - fedora-review tool refused to run due to this > * according to [1], Obsoletes should include a release higher than the > last available release of the old package > - If I understand this correctly, it should be: > Obsoletes: lmiwbem <= 0.6.0-3 Done. > * again according to [1], Provides should be listed twice - once with > %{?_isa} macro and once without: > Provides: lmiwbem = %{version}-%{release} > Provides: lmiwbem%{?_isa} = %{version}-%{release} Done. > > rpmlint findings: > * python-lmiwbem.spec: W: invalid-url Source0: > https://github.com/phatina/lmiwbem/releases/download/python-lmiwbem-0.6.0/ > python-lmiwbem-0.6.0.tar.gz HTTP Error 404: Not Found > The value should be a valid, public HTTP, HTTPS, or FTP URL. According to Github and rpmlint: Tarball for 0.7.0 is accessible, via several redirections. Rpmlint dislikes this, but this is the way, how we release new versions of lmiwbem. > > [1] > http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages Thank you.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 37 files have unknown license. Detailed output of licensecheck in /home/miminar/Downloads/python-lmiwbem/python-lmiwbem/licensecheck.txt [!]: License file installed when any subpackage combination is installed. *-doc package is missing LICENSE file [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python2.7/site- packages/lmiwbem(lmiwbem) [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. *-doc package is missing Provides and Obsoletes [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [!]: Package complies to the Packaging Guidelines *-doc package should be noarch [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python BuildRequires should contain python-devel2 Unversioned python macros (python_sitelib) are deprecated [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- lmiwbem-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1761280 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-lmiwbem-0.7.0-1.fc23.x86_64.rpm python-lmiwbem-doc-0.7.0-1.fc23.x86_64.rpm python-lmiwbem-0.7.0-1.fc23.src.rpm python-lmiwbem-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python-lmiwbem-0.7.0/html/_static/jquery.js python-lmiwbem.src: W: invalid-url Source0: https://github.com/phatina/python-lmiwbem/releases/download/python-lmiwbem-0.7.0/python-lmiwbem-0.7.0.tar.gz HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python-lmiwbem-doc (rpmlib, GLIBC filtered): python-lmiwbem (rpmlib, GLIBC filtered): boost-python libboost_python.so.1.57.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpegclient.so.1()(64bit) libpegcommon.so.1()(64bit) libpeglistener.so.1()(64bit) libpython2.7.so.1.0()(64bit) libslp.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) openslp python python(abi) rtld(GNU_HASH) tog-pegasus-libs Provides -------- python-lmiwbem-doc: python-lmiwbem-doc python-lmiwbem-doc(x86-64) python-lmiwbem: lmiwbem lmiwbem(x86-64) python-lmiwbem python-lmiwbem(x86-64) Unversioned so-files -------------------- python-lmiwbem: /usr/lib64/python2.7/site-packages/lmiwbem/lmiwbem_core.so Source checksums ---------------- https://github.com/phatina/python-lmiwbem/releases/download/python-lmiwbem-0.7.0/python-lmiwbem-0.7.0.tar.gz : CHECKSUM(SHA256) this package : 2846b47461fc931478dd1c0c1ab98a6a82a41e8134af227eefaa9d35bc6e3a25 CHECKSUM(SHA256) upstream package : 2846b47461fc931478dd1c0c1ab98a6a82a41e8134af227eefaa9d35bc6e3a25 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: python-lmiwbem-0.7.0/configure.ac:23
Spec URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem.spec SRPM URL: https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem-0.7.1-1.fc23.src.rpm
LGTM, good work!
New Package SCM Request ======================= Package Name: python-lmiwbem Short Description: Python WBEM Client Upstream URL: https://github.com/phatina/python-lmiwbem/ Owners: phatina Branches: f21 f22 InitialCC:
Git done (by process-git-requests).