Created attachment 994352 [details] engine.log, notifier.log Description of problem: according to our TCMS test case we should receive if DWH gets stopped an event notification with: History Service stopped/History Service started But I received: ETL Service stopped/ETL Service started This is confusing, let's suppose nobody knows what ETL is, but an user of DWH knows what DWH is :) # egrep 'DWH.*(stop|start)' /usr/share/doc/ovirt-engine/AuditLogMessages.properties DWH_STOPPED=History Service stopped. DWH_STARTED=History Service started. engine=# select log_time,log_type_name,message from audit_log where message ilike '%service%' order by log_time ; log_time | log_type_name | message ----------------------------+---------------+------------------------------------------------------------------------------------------------- 2015-01-26 13:09:27.9+01 | DWH_ERROR | ETL service sampling has encountered an error. Please consult the service log for more details. 2015-01-26 13:15:18.938+01 | DWH_STOPPED | ETL Service Stopped 2015-01-26 13:29:23.89+01 | DWH_STARTED | ETL Service Started 2015-02-13 19:22:39.736+01 | DWH_ERROR | ETL service sampling has encountered an error. Please consult the service log for more details. 2015-02-17 09:52:16.347+01 | DWH_STOPPED | ETL Service Stopped 2015-02-23 10:35:10.135+01 | DWH_STARTED | ETL Service Started 2015-02-23 10:46:27.229+01 | DWH_STOPPED | ETL Service Stopped 2015-02-23 10:50:23.535+01 | DWH_STARTED | ETL Service Started (8 rows) Seems like there's somewhere wrong translation of this message [1] https://tcms.engineering.redhat.com/run/228998/#caserun_9075589 Version-Release number of selected component (if applicable): rhevm-3.5.0-0.30.el6ev.noarch How reproducible: 100% Steps to Reproduce: 1. configure mail notification 2. assign 'History Service Stopped' in Admin Portal -> Users 3. stop DWHd Actual results: ETL Service stopped/ETL Service started Expected results: History Service stopped/History Service started Additional info: let's not confuse the user
As far as I know, ETL is a common terminology. However, not sure what the user expects here. Yaniv/Shirly?
The message is correct and ETL (Extract Transform Load) is common terminology when it comes to DWH. The is the process for collecting the data into the Data warehouse (DWH).
Based on Comment #2, closing as notabug.
Have you taken into account content of AuditLogMessages.properties? Why do you name it DWH_(STOPPED|STARTED)? Why do you name it 'History Service Stopped' in Admin Portal? # egrep 'DWH.*(stop|start)' /usr/share/doc/ovirt-engine/AuditLogMessages.properties DWH_STOPPED=History Service stopped. DWH_STARTED=History Service started. Look at the confusion from user point of view, not a developer one. At least there are inconsistencies...
The message that we add to the audit log is ""ETL Service Stopped" and "ETL Service Started" This should also be the message in the Admin portal. Not sure why the message is different for the user.
Not sure what's the question here. I see that this was added for bug 1119186.
Please remove the : DWH_STOPPED=History Service stopped. DWH_STARTED=History Service started. DWH_ERROR=Error in History Service. from the engine code. These messages are passed from the ETL service directly as DWH_STOPPED=ETL Service stopped. DWH_STARTED=ETL Service started.
(In reply to Shirly Radco from comment #7) > Please remove the : > DWH_STOPPED=History Service stopped. > DWH_STARTED=History Service started. > DWH_ERROR=Error in History Service. > > from the engine code. > > These messages are passed from the ETL service directly as > DWH_STOPPED=ETL Service stopped. > DWH_STARTED=ETL Service started. After checking that it seems that engine-notifier uses those events in order to send email notifications on those events So, IIUC , all that we should do is to change "history" with "ETL" in the reported events Please approve
We do add these exact events during the etl service to the audit log, so do we keep duplicates?
(In reply to Shirly Radco from comment #9) > We do add these exact events during the etl service to the audit log, > so do we keep duplicates? The notification service handle messages also when ETL exits unexpectedly, so I don't think that this is a duplication ...
ok, ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764.el6.noarch assigned 'ETL Service Stopped' and got mail notification with 'ETL Service Stopped'