Bug 1195553 (ghc-control-monad-free) - Review Request: ghc-control-monad-free - Free monads and monad transformers
Summary: Review Request: ghc-control-monad-free - Free monads and monad transformers
Keywords:
Status: CLOSED ERRATA
Alias: ghc-control-monad-free
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: ghc-prelude-extras
Blocks: ghc-wizards
TreeView+ depends on / blocked
 
Reported: 2015-02-24 04:22 UTC by Ben Boeckel
Modified: 2015-03-13 16:58 UTC (History)
3 users (show)

Fixed In Version: ghc-wizards-1.0.1-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-13 16:58:04 UTC
Type: ---
Embargoed:
petersen: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ben Boeckel 2015-02-24 04:22:49 UTC
Spec URL: http://mathstuf.fedorapeople.org//ghc-control-monad-free.spec
SRPM URL: http://mathstuf.fedorapeople.org//ghc-control-monad-free-0.6.1-1.fc23.src.rpm

Description:
This package provides datatypes to construct Free monads, Free monad
transformers, and useful instances. In addition it provides the constructs to
avoid quadratic complexity of left associative bind, as explained in:

Janis Voigtlander, Asymptotic Improvement of Computations over Free Monads,
MPC'08/. http://www.janis-voigtlaender.eu/Voi08d.html

Comment 1 Jens Petersen 2015-02-26 07:45:47 UTC
cblrpm diff output:

--- ghc-control-monad-free.spec	2015-02-24 13:21:24.000000000 +0900
+++ ghc-control-monad-free.spec.cblrpm	2015-02-26 16:44:00.276452354 +0900
@@ -23,8 +23,8 @@
 transformers, and useful instances. In addition it provides the constructs to
 avoid quadratic complexity of left associative bind, as explained in:
 
-Janis Voigtlander, Asymptotic Improvement of Computations over Free Monads,
-MPC'08/. http://www.janis-voigtlaender.eu/Voi08d.html
+* Janis Voigtlander, /Asymptotic Improvement of Computations over Free Monads,
+MPC'08/.
 
 
 %package devel

Comment 2 Jens Petersen 2015-02-26 08:10:20 UTC
Builds fine in F22+ with ghc-7.8.4 - fails to build under F21 ghc-7.6.3.

License is Public Domain so no license file.

However according to http://packdeps.haskellers.com/reverse/control-monad-free
wizards needs 0.5.* of this package, so 0.6 seems too new.

It might be nice to ask upstream politely if they wouldn't like
to put the source under a proper FOSS license, like BSD.

Comment 3 Jens Petersen 2015-02-27 02:38:31 UTC
(In reply to Jens Petersen from comment #2)
> However according to
> http://packdeps.haskellers.com/reverse/control-monad-free
> wizards needs 0.5.* of this package, so 0.6 seems too new.

Actually wizards builds fine with 0.6.

Comment 4 Jens Petersen 2015-02-27 03:22:42 UTC
The package looks fine to me.

- Public Domain
  (for the record I asked the authors about moving to BSD)
- standard Haskell packaging
- minimal cblrpm diff: see comment 1

Package is APPROVED

Comment 5 Ben Boeckel 2015-02-27 04:27:26 UTC
Upstream fixed the dep on control-monad-free here: <https://github.com/liamoc/wizards/commit/694ffef6034f6647b5f74ed07e8f3d5e7f4a46bf>. I'll cherry-pick if there isn't a new release by the time I upload.

New Package SCM Request
=======================
Package Name: ghc-control-monad-free
Short Description: Free monads and monad transformers
Upstream URL: http://github.com/pepeiborra/control-monad-free
Owners: mathstuf petersen
Branches: f20 f21 f22
InitialCC: haskell-sig

Comment 6 Gwyn Ciesla 2015-02-27 13:48:57 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2015-02-28 09:46:56 UTC
hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22

Comment 8 Fedora Update System 2015-02-28 16:41:55 UTC
Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, hledger-0.23.2-1.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 hledger-0.23.2-1.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2015-03-04 21:08:57 UTC
Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-03-13 16:58:04 UTC
ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.