Bug 1195660 - unable to set SATA serial with a spaces
Summary: unable to set SATA serial with a spaces
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Michal Privoznik
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-24 09:47 UTC by Alan Latteri
Modified: 2015-03-05 12:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-05 12:58:15 UTC
Embargoed:


Attachments (Terms of Use)

Description Alan Latteri 2015-02-24 09:47:42 UTC
Description of problem:
I am virtualzing a physical server for which I need to set the SCSI/SATA drive serial. It is comprised of 12 " " spaces then 8 letter/digits. If I exclude the spaces, the drive serial is not accurate. If I include the spaces I get the following error.

error: Failed to start domain test1
error: internal error: driver serial ' ABCD1234' contains unsafe characters



Version-Release number of selected component (if applicable):
virsh edit
Centos 7.0
3.19.0-1.el7.elrepo.x86_64
QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-60.el7.centos.7), Copyright (c) 2003-2008 Fabrice Bellard

How reproducible:
always

Steps to Reproduce:
1. use 12 spaces then 8 letter/digits as hard drive serial. example: "            ABCD1234"
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Michal Privoznik 2015-02-24 15:34:53 UTC
Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2015-February/msg00947.html

Comment 2 Alan Latteri 2015-03-05 01:08:39 UTC
wondering the status of this bug and patch roll into libvirt release.  this bug prevents me from using any software that utilizes Libvirt, e.g. overt.

Thanks.

Comment 3 Michal Privoznik 2015-03-05 12:58:15 UTC
I've just pushed the patch upstream:

commit 5aee81a0cb60308b8614ee37c0b69c1dde1f00d8
Author:     Michal Privoznik <mprivozn>
AuthorDate: Mon Feb 23 12:34:23 2015 +0100
Commit:     Michal Privoznik <mprivozn>
CommitDate: Thu Mar 5 13:35:55 2015 +0100

    qemu: Allow spaces in disk serial
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1195660
    
    There's been a bug report appearing on the qemu-devel list, that
    libvirt is unable to pass spaces in disk serial number [1]. Not only
    our RNG schema forbids that, the code is not prepared either. However,
    with a bit of escaping (if needed) we can allow spaces there.
    
    1: https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04041.html
    
    Signed-off-by: Michal Privoznik <mprivozn>

v1.2.13-60-g5aee81a


Note You need to log in before you can comment on or make changes to this bug.