Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1195738

Summary: Some storage domain properties cannot be defined when importing a storage domain using REST.
Product: [Retired] oVirt Reporter: Vered Volansky <vered>
Component: ovirt-engine-apiAssignee: Maor <mlipchuk>
Status: CLOSED CURRENTRELEASE QA Contact: Ori Gofen <ogofen>
Severity: medium Docs Contact:
Priority: high    
Version: 3.6CC: acanan, amureini, bugs, ecohen, eedri, gklein, lsurette, mlipchuk, rbalakri, vered, yeylon, ylavi
Target Milestone: ---   
Target Release: 3.5.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-engine-3.5.3_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-15 08:39:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1196169    

Description Vered Volansky 2015-02-24 13:32:23 UTC
Description of problem:
When importing a storage domain from webadmin, on can override custom connection parameters and wipe-after-delete.
In REST this is not an option (default values even if you specify these properties).

After a discussion with Maor - this might mean there might be a problem with the custom connection parameters when adding a storage domain through REST as well. Be aware when fixing/verifying this bug.

How reproducible:
100%

Comment 1 Allon Mureinik 2015-02-24 13:36:48 UTC
(In reply to Vered Volansky from comment #0)
> Description of problem:
> When importing a storage domain from webadmin, on can override custom
> connection parameters and wipe-after-delete.
> In REST this is not an option (default values even if you specify these
> properties).
What properties do you mean?
WAD is a domain property, not a connection property.

Comment 2 Vered Volansky 2015-02-24 13:39:25 UTC
(In reply to Allon Mureinik from comment #1)
> (In reply to Vered Volansky from comment #0)
> > Description of problem:
> > When importing a storage domain from webadmin, on can override custom
> > connection parameters and wipe-after-delete.
> > In REST this is not an option (default values even if you specify these
> > properties).
> What properties do you mean?
custom connection parameters and wipe-after-delete.
> WAD is a domain property, not a connection property.
The problem is with both (or maybe all five).

Comment 3 Allon Mureinik 2015-02-24 13:40:54 UTC
(In reply to Vered Volansky from comment #2)
> (In reply to Allon Mureinik from comment #1)
> > (In reply to Vered Volansky from comment #0)
> > > Description of problem:
> > > When importing a storage domain from webadmin, on can override custom
> > > connection parameters and wipe-after-delete.
> > > In REST this is not an option (default values even if you specify these
> > > properties).
> > What properties do you mean?
> custom connection parameters and wipe-after-delete.

Still not sure we're on the same page.
Do you mean the custom mount options?

Comment 4 Vered Volansky 2015-02-24 13:50:30 UTC
(In reply to Allon Mureinik from comment #3)
> (In reply to Vered Volansky from comment #2)
> > (In reply to Allon Mureinik from comment #1)
> > > (In reply to Vered Volansky from comment #0)
> > > > Description of problem:
> > > > When importing a storage domain from webadmin, on can override custom
> > > > connection parameters and wipe-after-delete.
> > > > In REST this is not an option (default values even if you specify these
> > > > properties).
> > > What properties do you mean?
> > custom connection parameters and wipe-after-delete.
> 
> Still not sure we're on the same page.
> Do you mean the custom mount options?
They are now called custom connection parameters. But yes.

Comment 5 Vered Volansky 2015-02-25 05:54:39 UTC
Just to be absolutely clear, the Custom Connection Parameters is now what used to be just "Advanced parameters" in the past for NFS.
For NFS it's:
NFS Version	
Retransmissions (#)
Timeout (deciseconds)
Additional mount options

For other storage types it's not necessarily under "Custom Connection Parameters", and may not consist of all these properties, only some.
The problem exist for these storage types as well.
For instance, "VFS Type" and "Mount Options" for POSIX.

Wipe-after-delete is always under "Advanced Parameters" now.

Comment 6 Maor 2015-02-28 16:47:42 UTC
(In reply to Vered Volansky from comment #5)
> Just to be absolutely clear, the Custom Connection Parameters is now what
> used to be just "Advanced parameters" in the past for NFS.
> For NFS it's:
> NFS Version	
> Retransmissions (#)
> Timeout (deciseconds)
> Additional mount options
> 
> For other storage types it's not necessarily under "Custom Connection
> Parameters", and may not consist of all these properties, only some.
> The problem exist for these storage types as well.
> For instance, "VFS Type" and "Mount Options" for POSIX.
> 
> Wipe-after-delete is always under "Advanced Parameters" now.

Looking in the documentation it appears connection properties should be supported (Not sure about Wipe After Delete though, since this was merged recently) see [1]

For example I used the following request:
<storage_domain>
    <name>DataDomainRest</name>
    <type>data</type>
    <storage>
        <address>10.35.16.2</address>
        <type>nfs</type>
        <path>/export/images/rnd/maor/data3</path>
        <nfs_retrans>1</nfs_retrans>
        <nfs_timeo>60</nfs_timeo>
        <nfs_version>V3</nfs_version>
    </storage>
    <host>
        <name>venus-vdsa.tlv.redhat.com</name>
    </host>
    <storage_format>v3</storage_format>
</storage_domain>

Is that still blocks BZ1196169?


[1] https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.5/html-single/Technical_Guide/index.html#storageconnection

Comment 7 Maor 2015-03-01 16:34:55 UTC
Depending on the fix for bug https://bugzilla.redhat.com/1195724, wipe_after_delete will also be supported.
Moving this bug to Modify as well

Comment 8 Eyal Edri 2015-03-22 14:18:03 UTC
bug has no tracker, so no way to know if the bug is in latest 3.5.1 vt14.1 build.
please check and move bug to ON_QA if it's included.
if this bug is a text-only and doesn't include a fix, please move to on_qa if the fix is in vt14.1.

Comment 9 Maor 2015-03-22 17:03:20 UTC
Since https://bugzilla.redhat.com/show_bug.cgi?id=1195724 is also Modify, I'm moving the bug back to Modify status, since this fix is dependent on BZ1195724

Comment 10 Eyal Edri 2015-03-22 17:34:45 UTC
you can't make a bug targeted to 3.5.2 depend on a future version - 3.5.3.
both have to be on the same version, if the other bug is really fixed only for 3.5.3, please update this bug TR as well.

Comment 11 Allon Mureinik 2015-03-22 18:57:46 UTC
These are both 3.5.3 bugs.

Comment 12 Maor 2015-04-12 16:48:32 UTC
(In reply to Eyal Edri from comment #10)
> you can't make a bug targeted to 3.5.2 depend on a future version - 3.5.3.
> both have to be on the same version, if the other bug is really fixed only
> for 3.5.3, please update this bug TR as well.

Removing the needinfo since I see that Allon already did it.

Comment 13 Eyal Edri 2015-05-21 10:54:10 UTC
i don't really follow the logic on this bug, but according to comment 9, this should move to on_qa?

Comment 14 Allon Mureinik 2015-05-21 12:20:36 UTC
(In reply to Eyal Edri from comment #13)
> i don't really follow the logic on this bug, but according to comment 9,
> this should move to on_qa?
Yes, this is correct.
This bug is a different scenario than bug 1195724 (QA-wise), but that patch solved this one too, so it was not moved automatically to ON_QA. Moved it manually.

Comment 15 Ori Gofen 2015-05-26 09:08:05 UTC
Verified using vt 15

Comment 16 Sandro Bonazzola 2015-06-15 08:39:23 UTC
This is an automated message.
oVirt 3.5.3 has been released on June 15th 2015 and should include the fix for this BZ. Moving to closed current release.