Bug 1196101 - virt-builder --upload option doesn't work to a FAT partition
Summary: virt-builder --upload option doesn't work to a FAT partition
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Maros Zatko
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-25 10:10 UTC by Richard W.M. Jones
Modified: 2015-04-08 18:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-08 12:47:38 UTC
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2015-02-25 10:10:10 UTC
Description of problem:

The aarch64 Fedora 21 image uses EFI and therefore has a
FAT partition mounted under /boot/efi.  Trying to use
the virt-builder --upload option fails:

$ touch /tmp/test
$ virt-builder --arch aarch64 fedora-21 \
  --upload /tmp/test:/boot/efi/test
[...]
virt-builder: error: libguestfs error: chown: /boot/efi/test: 1000.1000: 
Operation not permitted

Enabling trace shows that we're running chmod + chown (why?)

libguestfs: trace: chmod 420 "/boot/efi/test"
libguestfs: trace: chmod = 0
libguestfs: trace: chown 1000 1000 "/boot/efi/test"
libguestfs: trace: chown = -1 (error)

It should probably detect if the mountpoint is FAT and
avoid the chown at least.

Version-Release number of selected component (if applicable):

virt-builder 1.29.24

How reproducible:

100%

Comment 1 Maros Zatko 2015-04-08 18:05:38 UTC
fixed in commit e6dadd6aca139792863cd3d274270095ec49a34e
and commit 6297534091666ccb7a5192763b53a4350cb550e3


Note You need to log in before you can comment on or make changes to this bug.