Bug 1196106 - [guided rule editor] duplicate @Position value not handled well
Summary: [guided rule editor] duplicate @Position value not handled well
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ER5
: 6.2.0
Assignee: Walter Medvedeo
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-25 10:22 UTC by Zuzana Krejčová
Modified: 2020-03-27 19:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-03-27 19:46:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Validaton error for master (12.34 KB, image/png)
2015-10-14 15:08 UTC, Walter Medvedeo
no flags Details
Validaton error for 6.3.x (15.00 KB, image/png)
2015-10-14 15:09 UTC, Walter Medvedeo
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1173089 0 high CLOSED Default Position value doesn't take into account superclasses 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1196105 0 medium CLOSED Superclasses and @Position on fields - duplicate position value not detected 2021-02-22 00:41:40 UTC

Internal Links: 1173089 1196105

Description Zuzana Krejčová 2015-02-25 10:22:15 UTC
Description of problem:
See description in bug 1173089 comment 0.
While the issue of defaults was fixed (by not adding the annotation automatically), the issue for duplicate position values persists.

The Error pop-up in GRE needs not to be blank - there should be a message of why the validation fails.


Version-Release number of selected component (if applicable):
6.1 ER5


Steps to Reproduce:
1. Create a data object C1 with field f1, set Position to 0. Save.
2. Create a data object C2, set the superclass to C1, add field f2, set Position to 0. Save.
3. Create a guided rule, add C2 to 'when' section.
4. Validate the guided rule.


Actual results:
Step 4 - Error pop-up with no message, validation fails.


Expected results:
Step 4 - Error pop-up warning about duplicate position, validation fails.

Comment 2 Walter Medvedeo 2015-02-26 10:04:37 UTC
Mike, given that eventually a user can push whatever "malicious" .java files into the git repository, I gues this is more related to how the guided rule editor manage certain errors.
But no problem, I can take a look.

Comment 3 manstis 2015-02-26 15:35:30 UTC
Walter, I agree... but it might be that it's Drools Core handling of the problem that needs fixing... if KieBuilder detected the issue and raised a Build error/warning.

Comment 4 Walter Medvedeo 2015-02-26 16:36:00 UTC
fixed in master with the following commit:

https://github.com/droolsjbpm/kie-wb-common/commit/b2910ffc0

Comment 5 Walter Medvedeo 2015-10-14 15:07:01 UTC
I've tested the issue both in master and 6.3.x branches and now the expected validation error for the guided rule described use case is shown. See attached screenshots.

Comment 6 Walter Medvedeo 2015-10-14 15:08:09 UTC
Created attachment 1082865 [details]
Validaton error for master

Comment 7 Walter Medvedeo 2015-10-14 15:09:37 UTC
Created attachment 1082866 [details]
Validaton error for 6.3.x


Note You need to log in before you can comment on or make changes to this bug.