Bug 1196186 - Review Request: perl-DBIx-Class-Schema-Config - Credential Management for DBIx::Class
Summary: Review Request: perl-DBIx-Class-Schema-Config - Credential Management for DBI...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-25 12:55 UTC by Jitka Plesnikova
Modified: 2015-03-09 08:33 UTC (History)
2 users (show)

Fixed In Version: perl-DBIx-Class-Schema-Config-0.001011-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-26 10:00:41 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-02-25 12:55:13 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-DBIx-Class-Schema-Config/perl-DBIx-Class-Schema-Config.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-DBIx-Class-Schema-Config/perl-DBIx-Class-Schema-Config-0.001011-1.fc23.src.rpm

Description: 
DBIx::Class::Schema::Config is a subclass of DBIx::Class::Schema that
allows the loading of credentials & configuration from a file. The actual
code itself would only need to know about the name used in the
configuration file. This aims to make it simpler for operations teams to
manage database credentials.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-02-25 13:44:26 UTC
Missing BRs:
- Module::Install::Metadata, via various calls in Makefile.PL
- Module::Install::WriteAll, via a call in Makefile.PL

You don't have to filter out ^perl(DBIx::Class)$; it's not used anywhere in the lib code (directly).

Comment 2 Jitka Plesnikova 2015-02-25 14:31:50 UTC
Updated. 
Links are same.

Comment 3 Petr Šabata 2015-02-25 15:50:54 UTC
Ack, approving.

Comment 4 Jitka Plesnikova 2015-02-25 15:56:49 UTC
New Package SCM Request
=======================
Package Name: perl-DBIx-Class-Schema-Config
Short Description: Credential Management for DBIx::Class
Upstream URL: http://search.cpan.org/dist/DBIx-Class-Schema-Config/
Owners: jplesnik ppisar psabata
Branches: f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-02-25 21:13:24 UTC
Git done (by process-git-requests).

Comment 6 Jitka Plesnikova 2015-02-26 10:00:41 UTC
Thank you for the review and the repository.

Comment 7 Fedora Update System 2015-02-26 11:22:27 UTC
perl-DBIx-Class-Schema-Config-0.001011-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-DBIx-Class-Schema-Config-0.001011-1.fc20

Comment 8 Fedora Update System 2015-02-26 11:22:42 UTC
perl-DBIx-Class-Schema-Config-0.001011-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-DBIx-Class-Schema-Config-0.001011-1.fc21

Comment 9 Fedora Update System 2015-03-09 08:22:11 UTC
perl-DBIx-Class-Schema-Config-0.001011-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2015-03-09 08:33:34 UTC
perl-DBIx-Class-Schema-Config-0.001011-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.