Bug 1196650 - dht-common.h:911:1: warning: inline function 'dht_lock_count' declared but never defined
Summary: dht-common.h:911:1: warning: inline function 'dht_lock_count' declared but ne...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
urgent
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-26 13:01 UTC by Niels de Vos
Modified: 2015-05-14 17:46 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:29:12 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2015-02-26 13:01:27 UTC
Description of problem:
Nightly builds of glusterfs against Fedora Rawhide fail with the following errors:

In file included from unittest/dht_layout_unittest.c:11:0:
./dht-common.h:911:1: error: inline function 'dht_lock_count' declared but never defined [-Werror]
 dht_lock_count (dht_lock_t **lk_array, int lk_count);
 ^
cc1: all warnings being treated as errors

Version-Release number of selected component (if applicable):
current master branch

Additional info:

Full log:
https://copr-be.cloud.fedoraproject.org/results/devos/glusterfs/fedora-rawhide-i386/glusterfs-3.7dev-0.614.git1fd540c.autobuild/build.log

Comment 1 Anand Avati 2015-02-26 13:02:24 UTC
REVIEW: http://review.gluster.org/9760 (dht: fix for dht_lock_count() compile error) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-02-26 17:14:10 UTC
COMMIT: http://review.gluster.org/9760 committed in master by Raghavendra G (rgowdapp) 
------
commit f364d963b63a13979d07f7871a3c02b205e20bed
Author: Niels de Vos <ndevos>
Date:   Thu Feb 26 13:59:02 2015 +0100

    dht: fix for dht_lock_count() compile error
    
    dht-common.h includes a function definition with "inline", but the
    function is not declared in the header. Dropping the "inline" compile
    directive so that linking against .o files works correctly.
    
    BUG: 1196650
    Change-Id: I105be591125b29cd455769b0c4ff22d6e139227d
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9760
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 3 Niels de Vos 2015-05-14 17:29:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:51 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:46:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.