Created attachment 995697 [details] patch to use cmake to build Description of problem: Building double-conversion with cmake would install the cmake files that would allow other cmake using project to automatically find the double-conversion library - in particular InsightToolkit. The other change here is dropping the _pic.a static library and making the .a build with -fPIC. In general now, .a's are useless without -fPIC. Although I'd just drop the static lib completely.
Still have some issues to fix with this...
Looks OK, except that if would be good to fix the hardcoded paths upstream if possible, instead of calling sed. Also, minor detail: could you use pushdir/popdir and indent the code between them instead of using "cd build-static ... cd -"? Looks clearer to me.
(In reply to Milan Bouchet-Valat from comment #2) > Looks OK, except that if would be good to fix the hardcoded paths upstream > if possible, instead of calling sed. Yeah, upstream issue is here: https://github.com/floitsch/double-conversion/issues/8 > Also, minor detail: could you use pushdir/popdir and indent the code between > them instead of using "cd build-static ... cd -"? Looks clearer to me. Okay.
Milan - I've pushed an updated cmake branch. Can you take a look? Thanks.
Thanks. Looks good to me, assuming you've tested it. Feel free to merge, build and make updates if you need them. Maybe just change this: cd build-shared ctest -V to build-shared/ctest -V or to pushd build-shared ctest -V popd
Done, thanks.