Spec URL: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan.spec SRPM URL: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan-1.0.0-2.fc21.src.rpm Description: wakeonlan is a small OS independent java program that sends 'magic packets' to wake-on-lan enabled ethernet adapters and motherboards in order to switch on the called machine. It runs on any machine with an installed 1.4+ java runtime. wakeonlan can be used by command line or by a graphical user interface. You can use wakeonlan as a java library too. It provides a utility class to wake up remote machines. See wakeonlan javadoc for more information. Fedora Account System Username: leamas rpmlint: Spelling errors(4), incorrect-fsf-address, no-manual-page-for-binary fedora-review: One message about jar files in source. Handled by removing in %prep. Scratch build: https://copr.fedoraproject.org/coprs/leamas/harctoolbox/builds/
Informed upstream about the bad fsf address: https://sourceforge.net/p/java-wakeonlan/discussion/305972/thread/4a546ed2/
This is my first java package, blocking on FE-JAVASIG to see if anyone might look into this.
Please Group: System Environment/Libraries << remove BuildRequires: maven-local << change with javapackages-local Requires: jsap << remove, Requires are managed by maven tools
forgot this Patch1: 0001-Update-target-and-source-to-1.5.patch << now for rawhide minimum source/target is 1.6
see your patch now this haven't few sense, koji haven't web acces - <link href="http://java.sun.com/j2se/1.4.2/docs/api/"/> + <link href="http://java.sun.com/j2se/1.5.0/docs/api/"/> should better BuildRequires: java-javadoc <link href="/usr/share/javadoc/java/"/>
other question, the package provides a GUI, can you provides a desktop file? BuildRequires: desktop-file-utils BuildRequires: ImageMagick mkdir -p %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/ convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 %{name}-inspector.png \ %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/ cat > %{name}.desktop _EOF [Desktop Entry] Name=%{name} GenericName=%{name} Comment=A wake on lan client Exec=%{name} Icon=%{name} Terminal=false Type=Application Categories=Network; _EOF desktop-file-install --vendor="" --dir=%{buildroot}%{_datadir}/applications %{name}.desktop desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Maven packages should use new style packaging Note: If possible update your package to latest guidelines See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1197499-java-wakeonlan/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr/share /maven-metadata [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java- wakeonlan-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: java-wakeonlan-1.0.0-2.fc23.noarch.rpm java-wakeonlan-javadoc-1.0.0-2.fc23.noarch.rpm java-wakeonlan-1.0.0-2.fc23.src.rpm java-wakeonlan.noarch: W: spelling-error %description -l en_US lan -> LAN, lab, lam java-wakeonlan.noarch: W: spelling-error %description -l en_US ethernet -> Ethernet, ether net, ether-net java-wakeonlan.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment java-wakeonlan.noarch: W: spelling-error %description -l en_US javadoc -> java doc, java-doc, avocado java-wakeonlan.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan/COPYING java-wakeonlan.noarch: W: no-manual-page-for-binary wakeonlan java-wakeonlan-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan-javadoc/COPYING java-wakeonlan.src: W: spelling-error %description -l en_US lan -> LAN, lab, lam java-wakeonlan.src: W: spelling-error %description -l en_US ethernet -> Ethernet, ether net, ether-net java-wakeonlan.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment java-wakeonlan.src: W: spelling-error %description -l en_US javadoc -> java doc, java-doc, avocado 3 packages and 0 specfiles checked; 2 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Diff spec file in url and in SRPM --------------------------------- --- /home/gil/1197499-java-wakeonlan/srpm/java-wakeonlan.spec 2015-03-01 22:59:45.018323112 +0100 +++ /home/gil/1197499-java-wakeonlan/srpm-unpacked/java-wakeonlan.spec 2015-03-01 20:48:11.000000000 +0100 @@ -61,7 +61,7 @@ %install rm -f %{buildroot}%{_bindir}/wakeonlan -mv deploy/doc/javadoc . - %jpackage_script wol.WakeOnLan "" "" jsap:wakeonlan wakeonlan + +mv deploy/doc/javadoc . %mvn_artifact de.moldaner:wakeonlan:%{version} deploy/wakeonlan.jar %mvn_install -J javadoc Requires -------- java-wakeonlan (rpmlib, GLIBC filtered): /bin/bash java-headless jpackage-utils jsap java-wakeonlan-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- java-wakeonlan: java-wakeonlan mvn(de.moldaner:wakeonlan) java-wakeonlan-javadoc: java-wakeonlan-javadoc Source checksums ---------------- http://www.moldaner.de/wakeonlan/download/wakeonlan-1.0.0.zip : CHECKSUM(SHA256) this package : dfcdb54eb1333b5f9be74d7f493f68fce496d031b9b81656740e8b2fd1d62e43 CHECKSUM(SHA256) upstream package : dfcdb54eb1333b5f9be74d7f493f68fce496d031b9b81656740e8b2fd1d62e43 Jar and class files in source ----------------------------- ./wakeonlan-1.0.0/lib/jsap.jar Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1197499 --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Issues: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/java-wakeonlan/ [!]: Package contains desktop file if it is a GUI application. [?]: Package is named according to the Package Naming Guidelines. [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). see comment above, and ignore: Requires: jsap << remove, Requires are managed by maven tools
if you do not hurry I could translate the properties files in Italian resources/*.properties
Created attachment 996898 [details] CMDResources_it.properties
Created attachment 996899 [details] ErrorResources_it.properties
Created attachment 996900 [details] UIResources_it.properties
Created attachment 996911 [details] UIResources_it.properties
Ooops convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 \ %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}.png
((In reply to gil cattaneo from comment #14) > Ooops > > convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 \ > %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}.png No problem (there are some other oops, icon cache etc. Already fixed)
(In reply to Alec Leamas from comment #15) > ((In reply to gil cattaneo from comment #14) > > Ooops > > > > convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 \ > > %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}.png > > No problem (there are some other oops, icon cache etc. Already fixed) in the spec file persist again the problem convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 \ %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}-inspector.png <<<< please use %dir %{_javadir}/%{name} change javac source/target to 1.6 id is no fixed in PATCH0 I attached some properties files if you want use install on the sub-folder resources
[?]: Package is named according to the Package Naming Guidelines. why suffix java-, already exist an other package with the same name? or in other upstream project?
(In reply to gil cattaneo from comment #17) > [?]: Package is named according to the Package Naming Guidelines. > why suffix java-, already exist an other package with the same name? or in > other upstream project? should be correct the name if the package or cat > %{name}.desktop << EOF [Desktop Entry] Name=%{name} <<<< GenericName=%{name} <<<< Comment=A wake on lan client Exec=%{name} <<<< Icon=%{name} <<<< Terminal=false Type=Application Categories=Network; EOF
In reply to gil cattaneo from comment #8) > Issues: > > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/java/java-wakeonlan/ Fixed. > [!]: Package contains desktop file if it is a GUI application. Fixed (and thanks for the icon handling lesson!) > [?]: Package is named according to the Package Naming Guidelines. Corner case. "wakeonlan" is a rether generic name which IMHO is best avoided. So I used the somewhat better sourceforge project name "java-wakeonline". > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see attached > diff). Hmpf. Sorry. > if you do not hurry I could translate the properties files in Italian > resources/*.properties I'm in no hurry, If you add the Italian stuff I'll fix the Swedish :) - Added Italian and Swedish translations. - Fixed desktop file, notably Exec: field. New links: spec: : https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan-1.0.0-3.fc21.src.rpm srpm: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan-1.0.0-3.fc21.src.rpm
Oops... Spec url: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan.spec
Last-minute changes introduced an error in the launcher script. I'm re-generating release 3, same links
(In reply to Alec Leamas from comment #21) > Last-minute changes introduced an error in the launcher script. I'm > re-generating release 3, same links in the spec file should be corretedt the name of the icon/s
the patch (In reply to Alec Leamas from comment #19) > In reply to gil cattaneo from comment #8) > > if you do not hurry I could translate the properties files in Italian > > resources/*.properties > > I'm in no hurry, If you add the Italian stuff I'll fix the Swedish :) > > - Added Italian and Swedish translations. don't use CMDResources_it.properties
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils IGNORE - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text IGNORE - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' IGNORE ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1197499-java-wakeonlan/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-metadata, /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor, /usr/share/licenses, /usr/share/maven-metadata [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in java-wakeonlan [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java- wakeonlan-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: java-wakeonlan-1.0.0-3.fc23.noarch.rpm java-wakeonlan-javadoc-1.0.0-3.fc23.noarch.rpm java-wakeonlan-1.0.0-3.fc23.src.rpm java-wakeonlan.noarch: W: spelling-error %description -l en_US lan -> LAN, lab, lam java-wakeonlan.noarch: W: spelling-error %description -l en_US ethernet -> Ethernet, ether net, ether-net java-wakeonlan.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment java-wakeonlan.noarch: W: spelling-error %description -l en_US javadoc -> java doc, java-doc, avocado java-wakeonlan.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan/COPYING java-wakeonlan.noarch: W: no-manual-page-for-binary wakeonlan java-wakeonlan-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan-javadoc/COPYING java-wakeonlan.src: W: spelling-error %description -l en_US lan -> LAN, lab, lam java-wakeonlan.src: W: spelling-error %description -l en_US ethernet -> Ethernet, ether net, ether-net java-wakeonlan.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment java-wakeonlan.src: W: spelling-error %description -l en_US javadoc -> java doc, java-doc, avocado 3 packages and 0 specfiles checked; 2 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- java-wakeonlan (rpmlib, GLIBC filtered): /bin/bash /bin/sh java-headless jpackage-utils jsap java-wakeonlan-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- java-wakeonlan: application() application(java-wakeonlan.desktop) java-wakeonlan mvn(de.moldaner:wakeonlan) java-wakeonlan-javadoc: java-wakeonlan-javadoc Source checksums ---------------- http://www.moldaner.de/wakeonlan/download/wakeonlan-1.0.0.zip : CHECKSUM(SHA256) this package : dfcdb54eb1333b5f9be74d7f493f68fce496d031b9b81656740e8b2fd1d62e43 CHECKSUM(SHA256) upstream package : dfcdb54eb1333b5f9be74d7f493f68fce496d031b9b81656740e8b2fd1d62e43 Jar and class files in source ----------------------------- ./wakeonlan-1.0.0/lib/jsap.jar Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1197499 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Issues: java-wakeonlan.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan/COPYING java-wakeonlan-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/java-wakeonlan-javadoc/COPYING http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Suggestion: use also https://bugzilla.redhat.com/attachment.cgi?id=996898 CMDResources_it.properties fix icon name is not %{_datadir}/icons/hicolor/64x64/apps/%{name}-inspector.png but %{_datadir}/icons/hicolor/64x64/apps/%{name}.png if possible repackage the source archive and remove ./wakeonlan-1.0.0/lib/jsap.jar
(In reply to gil cattaneo from comment #25) > java-wakeonlan.noarch: E: incorrect-fsf-address > /usr/share/licenses/java-wakeonlan/COPYING I have informed upstream about this (comment #1) > Suggestion: > use also https://bugzilla.redhat.com/attachment.cgi?id=996898 > CMDResources_it.properties Of course, sorry I missed that. It was certainly not on purpose. Fixed. > fix icon name > is not %{_datadir}/icons/hicolor/64x64/apps/%{name}-inspector.png but > %{_datadir}/icons/hicolor/64x64/apps/%{name}.png Fixed > if possible repackage the source archive and remove > ./wakeonlan-1.0.0/lib/jsap.jar Certainly possible, but is it a good idea? The GL [1] requires us to remove the jars in %prep, but there is nothing about repacking the source in such cases. And as one of the fedora-review maintainers I can confirm that the message just is a heads up that there is jars to deal with. Still on release 3, new changelog entry , same links: spec: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan.spec srpm: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan-1.0.0-3.fc21.src.rpm [1] http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
Please fix Diff spec file in url and in SRPM --------------------------------- --- /home/gil/1197499-java-wakeonlan/srpm/java-wakeonlan.spec 2015-03-02 11:41:18.803202312 +0100 +++ /home/gil/1197499-java-wakeonlan/srpm-unpacked/java-wakeonlan.spec 2015-03-02 09:08:52.000000000 +0100 @@ -11,7 +11,5 @@ # Build configuration, no need to upstream. Patch1: 0001-Update-target-and-source-to-1.5.patch - # Will upstream -Patch2: 0002-Adding-Swedish-and-Italian-translations.patch - +Patch2: 0002-Adding-Swedich-and-Italian-translations.patch BuildRequires: ant-junit @@ -86,5 +84,5 @@ mkdir -p %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/ convert etc/javaws/wakeonlan64x64.gif -geometry 64x64 \ - %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}.png + %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}-inspector.png
This is odd, very odd. Have you cleared the browser cache? Everything looks good to me, but I run scp once again.
(In reply to Alec Leamas from comment #28) > This is odd, very odd. Have you cleared the browser cache? Everything looks > good to me, but I run scp once again. yes, now retry ...
BTW: Using both desktop-file-install and desktop-file-validate is redundant, isn't it?
(In reply to Alec Leamas from comment #30) > BTW: Using both desktop-file-install and desktop-file-validate is redundant, > isn't it? see http://www.freedesktop.org/wiki/Software/desktop-file-utils/ as suggest the name: one install the file the other one check if everything is okay, as you want, if you want to remove it is to your discretion BuildRequires: jpackage-utils is unnecessary, but should prevent some rpmlint warning
APPROVED
(In reply to gil cattaneo from comment #31) > as suggest the name: one install the file the other one check if everything > is okay, as you want, if you want to remove it is to your discretion Actually, they both do the same validating. Many thanks for the review! I'm not really in the position to offer you a java review in return. That said, I owe you one, should you need to review something else.
New Package SCM Request ======================= Package Name: java-wakeonlan Short Description: Wake On Lan client and java library Upstream URL: http://www.moldaner.de/wakeonlan Owners: leamas Branches: f21 f22 InitialCC:
(In reply to Alec Leamas from comment #33) > (In reply to gil cattaneo from comment #31) > > > as suggest the name: one install the file the other one check if everything > > is okay, as you want, if you want to remove it is to your discretion > > Actually, they both do the same validating. > > Many thanks for the review! I'm not really in the position to offer you a > java review in return. That said, I owe you one, should you need to review > something else. should be easily review https://bugzilla.redhat.com/show_bug.cgi?id=834574 block oVirt package, your discretion, thanks for the patience
WARNING: Requested package name java-wakeonlan doesn't match bug summary java-wakeonline
Git done (by process-git-requests).
rawhide, f21, f22 built OK. Closing bug