Bug 1197975

Sachin,

your assumption that the host should be provisioned is not correct. You need to provide it some options (host group or individual options). In case when Operating System is not set, Foreman returns this ugly error.

Setting low priority, does not need to be in 6.1 GA.

In other words: we will fix Foreman to return "Operating System was not set, cannot continue". Thus low priority.

Thanks Lukas.. yeah.. error should be user friendly.

Created attachment 1001434 [details]
undefine method `boot_filename_error` when user submit the new host form without filling anything

Bryan Kearney pushed to branch SATELLITE-6.1.0 at Satellite6 / foreman_discovery
46a9b568   Merge branch 'cherry-picks-2.0.1' into 'SATELLITE-6.1.0'
2ea063d7   refs #9546 - moving host_converter to proper directory for rails

Reported issue is still reproducible with:

sat6.1 GA snap1 compose 2 (Satellite-6.1.0-RHEL-7-20150424.0)


[root@cloud-qe-9 ~]# curl -k -u admin:changeme  -H "Content-Type: application/json" -X PUT 'https://cloud-qe-9.idmqe.lab.eng.bos.redhat.com/api/v2/discovered_hosts/3'
{
  "error": {"message":"undefined method `boot_filename' for nil:NilClass"}
}

The compose is using a version of discovery prior to Bryan's merge.
The package needs to be rebuilt with the changes and then tested.
Moving to post until there is a new package.

Issue is still reproducible with sat6.1 GA Snap2 (Satellite-6.1.0-RHEL-7-20150429.2)

]# curl -k -u admin:changeme  -H "Content-Type: application/json" -X PUT 'https://dhcp201-172.englab.pnq.redhat.com/api/v2/discovered_hosts/2'
{
  "error": {"message":"undefined method `boot_filename' for nil:NilClass"}
}

Just for clarifycation, you are sending invalid intput, there are some input data required. To fix this we need to:

- require discovered_host parameter in the docs
- programatially verify that hostgroup id is present OR all other parameters are present
- fix the boot_filename error in foreman core (I was under impression this was already fixed)

new patch at https://github.com/theforeman/foreman/pull/2378

Ori heads up - Bryan's bot is doing POST automatically. You need a downstream PR here.

Verified with sat6.1 GA snap5.

I can provision the discovered host via api and didn't see the reported issue:

 [root@ibm-x3550m3-06 pxelinux.cfg]# curl -i -k -u admin:changeme  -H "Accept: application/json" -X GET 'https://ibm-x3550m3-06.lab.eng.brq.redhat.com/api/v2/discovered_hosts/'
HTTP/1.1 200 OK
Date: Thu, 21 May 2015 13:10:33 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Foreman_version: 1.7.2
Foreman_api_version: 2
Apipie-Checksum: 555a0baaf6bde2915526836143b0e647
X-UA-Compatible: IE=Edge,chrome=1
Cache-Control: must-revalidate, private, max-age=0
X-Request-Id: ab26971a93accd64c2c886bb39c61a91
X-Runtime: 0.044195
X-Rack-Cache: miss
X-Powered-By: Phusion Passenger 4.0.18
Set-Cookie: _session_id=BAh7B0kiD3Nlc3Npb25faWQGOgZFRkkiJWZmOTllMDA1NGFiNmNjMTAwMDg5NTE0ZjExYzI3ZGIyBjsAVEkiC2xvY2FsZQY7AEZJIgdlbgY7AEY%3D--9927948ac6b7d346e4e304e6c9d6bdf795881664; path=/; secure; HttpOnly
ETag: "cc8805d3c6ba6320ecf4bdcdfdf06358"
Status: 200 OK
Transfer-Encoding: chunked
Content-Type: application/json; charset=utf-8

{
  "total": 1,
  "subtotal": 1,
  "page": 1,
  "per_page": 20,
  "search": null,
  "sort": {
    "by": null,
    "order": null
  },
  "results": [{"name":"mac525400124a1e","id":3,"ip":"192.168.100.13","mac":"52:54:00:12:4a:1e","last_report":"2015-05-21T13:00:22Z","subnet_id":1,"subnet_name":"libvirt","memory":2003,"disk_count":1,"disks_size":8192,"cpus":2,"organization_id":1,"organization_name":"Default Organization","location_id":2,"location_name":"Default Location"}]
}

This time I got proper error instead of undefined method `boot_filename' for nil:NilClass" 

# curl -i -k -u admin:changeme  -H "Content-Type: application/json" -X PUT 'https://ibm-x3550m3-06.lab.eng.brq.redhat.com/api/v2/discovered_hosts/3'
HTTP/1.1 422 Unprocessable Entity
Date: Thu, 21 May 2015 13:11:20 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Foreman_version: 1.7.2
Foreman_api_version: 2
Apipie-Checksum: 555a0baaf6bde2915526836143b0e647
X-UA-Compatible: IE=Edge,chrome=1
Cache-Control: no-cache
X-Request-Id: f66f51c3b7c2c5e4eac2eb6334c5cdbd
X-Runtime: 0.602420
X-Rack-Cache: invalidate, pass
X-Powered-By: Phusion Passenger 4.0.18
Set-Cookie: _session_id=BAh7B0kiD3Nlc3Npb25faWQGOgZFRkkiJTM1NjE3NDJlOTZkNDY3YmY0YjYyZjljYzI0ODZhN2RiBjsAVEkiC2xvY2FsZQY7AEZJIgdlbgY7AEY%3D--5964d9a35fe3381518f123e083202dbb552ac2c2; path=/; secure; HttpOnly
Status: 422 Unprocessable Entity
Transfer-Encoding: chunked
Content-Type: application/json; charset=utf-8

{
  "error": {"id":3,"errors":{"environment_id":["can't be blank"],"architecture_id":["can't be blank"],"operatingsystem_id":["can't be blank"],"domain_id":["can't be blank"],"root_pass":["should be 8 characters or more","should not be blank - consider setting a global or host group default"],"ptable_id":["can't be blank unless a custom partition has been defined"],"medium_id":["can't be blank"]},"full_messages":["Environment can't be blank","Architecture can't be blank","Operatingsystem can't be blank","Domain can't be blank","Root password should be 8 characters or more","Root password should not be blank - consider setting a global or host group default","Partition Table can't be blank unless a custom partition has been defined","Medium can't be blank"]}
}

Provisioning started as soon as I pass the hostgroup_id.

# curl -i -k -u admin:changeme  -H "Content-Type: application/json" -X PUT 'https://ibm-x3550m3-06.lab.eng.brq.redhat.com/api/v2/discovered_hosts/3' -d '{"hostgroup_id":1}'
HTTP/1.1 200 OK
Date: Thu, 21 May 2015 13:20:11 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Foreman_version: 1.7.2
Foreman_api_version: 2
Apipie-Checksum: 555a0baaf6bde2915526836143b0e647
X-UA-Compatible: IE=Edge,chrome=1
Cache-Control: max-age=0, private, must-revalidate
X-Request-Id: c670fcb81520212146054b7a110ec092
X-Runtime: 2.051427
X-Rack-Cache: invalidate, pass
X-Powered-By: Phusion Passenger 4.0.18
Set-Cookie: _session_id=BAh7B0kiD3Nlc3Npb25faWQGOgZFRkkiJTNiM2E2YTAxOTVkMDEwZjI2ZDhkZjVkZjAxMGY0MDhjBjsAVEkiC2xvY2FsZQY7AEZJIgdlbgY7AEY%3D--d6c540301f5fb191064908ba8790164dc093cc26; path=/; secure; HttpOnly
ETag: "180e176a576629592b4849bf39379148"
Status: 200 OK
Transfer-Encoding: chunked
Content-Type: application/json; charset=utf-8

{"name":"mac525400124a1e.lab.eng.brq.redhat.com","id":3}

This bug is slated to be released with Satellite 6.1.

This bug was fixed in version 6.1.1 of Satellite which was released on 12 August, 2015.