Hide Forgot
Spec URL: http://ueno.fedorapeople.org//gnome-characters.spec SRPM URL: http://ueno.fedorapeople.org//gnome-characters-3.15.91.1-1.fc21.src.rpm Description: Characters is a simple utility application to find and insert unusual characters.
I will take this for review. I see some rpmlint messages. fix them. I will check licensing and then post the review.
I've put updated spec and SRPM on the same location. It should fix the rpmlint errors previously reported, while it adds a new one: gnome-characters.src:24: W: unversioned-explicit-provides bundled(gnulib) I guess it can be ignored.
Suggestions: 1) we have a license macro now so you can use it as %doc NEWS README %license COPYING COPYINGv2 2) Above License: tag add following lines #Files from gtk-js-app are licensed under 3-clause BSD. #Other files are GPL 2.0 or later. 3) Package does not contain any libtool archives (.la) Note: gnome-characters : /usr/lib64/org.gnome.Characters/libgc.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries => Use in %install find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' Otherwise looks good. APPROVED.
Thanks Parag. New Package SCM Request ======================= Package Name: gnome-characters Short Description: Character map application for GNOME Upstream URL: https://git.gnome.org/browse/gnome-characters/ Owners: ueno Branches: f22 InitialCC:
Git done (by process-git-requests).
gnome-characters-3.15.92-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gnome-characters-3.15.92-1.fc22
gnome-characters-3.15.92-1.fc22 has been pushed to the Fedora 22 stable repository.