Bug 1198206 - virsh: don't exit on SIGINT
Summary: virsh: don't exit on SIGINT
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-03 14:55 UTC by Alexandru Gheorghe
Modified: 2016-04-10 20:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-10 20:29:54 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Alexandru Gheorghe 2015-03-03 14:55:32 UTC 
Description of problem:
----------------------
When doing SIGINT virsh console exits, is better to pass this and not treat the signal or at least exit if two ^C are detected one after the other. IMHO I would only exit on ^D (EOF).


Version-Release number of selected component (if applicable): 0.9.12.3-1+deb7u1 (Debian 7 wheezy)


How reproducible:
-----------------
Simply connect to a system with virsh and ^C  (virsh -c ...)


Actual results: exits from console


Expected results: bypass and ignore the signal


Additional info:
----------------
 the signal is dealt at (*i guess*) -> http://libvirt.org/git/?p=libvirt.git;a=blob;f=tools/virsh-console.c;h=f0faf8cb39f5242e023f785a5d3d957659c3ca0c;hb=refs/heads/master#l332   but we exit when we encounter it; seems virsh.c just sets the signal handler
Comment 1 Cole Robinson 2016-04-10 20:29:54 UTC 
SIGINT doesn't exit 'virsh console' for me with libvirt 1.3.3, so I suspect this was fixed
Note You need to log in before you can comment on or make changes to this bug.