Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1199075

Summary:	iobuf: Ref should be taken on iobuf through proper functions.
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	core	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, gluster-bugs, hchiramm
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:29:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Talur 2015-03-05 12:47:00 UTC

Description of problem:

We call __iobuf_ref directly without taking lock
and without going through iobuf_ref in some places.

It does not cause any functional problems but going
through the right way will help later in accounting refs.

Comment 1 Anand Avati 2015-03-05 12:51:41 UTC

REVIEW: http://review.gluster.org/9812 (iobuf: Do not call __iobuf_ref directly.) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Anand Avati 2015-03-06 10:36:26 UTC

REVIEW: http://review.gluster.org/9812 (iobuf: Do not call __iobuf_ref directly.) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 3 Anand Avati 2015-04-01 10:34:22 UTC

REVIEW: http://review.gluster.org/9812 (iobuf: Do not call __iobuf_ref directly) posted (#3) for review on master by Raghavendra Talur (rtalur)

Comment 4 Anand Avati 2015-04-02 10:08:40 UTC

COMMIT: http://review.gluster.org/9812 committed in master by Vijay Bellur (vbellur) 
------
commit 10b4ecb85c5009c6c7b9422bd5299ba43d8448a1
Author: Raghavendra Talur <rtalur>
Date:   Thu Mar 5 18:19:30 2015 +0530

    iobuf: Do not call __iobuf_ref directly
    
    iobuf_get will be creating the iobuf and
    hence lock is not necessary to increment ref.
    
    However, it is a good practice to call
    iobuf_ref instead of __iobuf_ref so that
    we have a single point to get refs and
    this can be used later to do mem
    accounting etc.
    
    Change-Id: I1fd328c3c463c23fd5f6df505ccb5c86f6207f28
    BUG: 1199075
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/9812
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 5 Niels de Vos 2015-05-14 17:29:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:35:52 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:38:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:46:13 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user