Description of problem: While reading the code found a bug that ec_iatt_combine is not combining all the iatt structure that are present in the response of the fop. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/9827 (cluster/ec: Refactor ec-dir-write) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/9827 committed in master by Vijay Bellur (vbellur) ------ commit 432355c9c6ca5937745f5d2b87ba391ad4877c92 Author: Pranith Kumar K <pkarampu> Date: Fri Mar 6 21:09:10 2015 +0530 cluster/ec: Refactor ec-dir-write - Also fixed iatt_combine to go over all the valid iatts Change-Id: I1d52d705ed0437f602357acde3e479cedb748681 BUG: 1199767 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9827 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Xavier Hernandez <xhernandez> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9981 (cluster/ec: Refactor inode-writev) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9982 (cluster/ec: Break cbk-list management into small parts) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9981 (cluster/ec: Refactor inode-writev) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9982 (cluster/ec: Break cbk-list management into small parts) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9981 (cluster/ec: Refactor inode-writev) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9982 (cluster/ec: Break cbk-list management into small parts) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9981 (cluster/ec: Refactor inode-writev) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9982 (cluster/ec: Break cbk-list management into small parts) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/10036 (cluster/ec: Have same ec_manager_* for [f]set/[f]removexattr) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/10036 (cluster/ec: Have same ec_manager_* for [f]set/[f]removexattr) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9981 (cluster/ec: Refactor inode-writev) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9982 (cluster/ec: Break cbk-list management into small parts) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/9981 committed in master by Vijay Bellur (vbellur) ------ commit 6e7d9a4e77a764e86bcde4e704ec05a3c84f9c11 Author: Pranith Kumar K <pkarampu> Date: Tue Mar 24 12:09:52 2015 +0530 cluster/ec: Refactor inode-writev All _cbk() functions in inode-write.c do same things, i.e. store op_ret/op_errno, stat structures if they are available and combine them. Moved this common operation into one function ec_inode_write_cbk() and made all the other _cbk() functions to use this instead. Change-Id: I2387b9f2d9598ced6299a26ea1900e9deb9fadc4 BUG: 1199767 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9981 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Dan Lambright <dlambrig>
REVIEW: http://review.gluster.org/10036 (cluster/ec: Have same ec_manager_* for [f]set/[f]removexattr) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/10036 committed in master by Vijay Bellur (vbellur) ------ commit c262430726635ce868558f299ad494734a173774 Author: Pranith Kumar K <pkarampu> Date: Sun Mar 29 10:13:45 2015 +0530 cluster/ec: Have same ec_manager_* for [f]set/[f]removexattr ec_manager_xxx() function for [f]set/[f]remove xattr is exactly same except the reporting part. So moved that to common function and use same ec_manager_xattr() function for all these fops. Change-Id: Iaa57023b800f8d1f3f6a827f4ceba9b0a0337336 BUG: 1199767 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/10036 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Xavier Hernandez <xhernandez>