From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4.2) Gecko/20040308 Description of problem: During code review found: leaked memory, not properly checking file descriptors before using them, a call to poll that returned -1 because of EINTR is being processed as if it were a valid return from poll, return code from forkCommand not being used at all, testing of device file susceptible to races in usernetctl, and userctl tests were unneccessarily case sensitive. Version-Release number of selected component (if applicable): initscripts-7.48 How reproducible: Always Steps to Reproduce: Found by code inpection Additional info: I have a patch that I will attach. Please consider applying it before fedora core 2 final.
Created attachment 99099 [details] Bug fix patch Please consider applying this.
Someone actually looked through process.c. Yikes, my condolances (it should really be taken out and shot.) Some of the forkCommand stuff is only correct due to the fact that it's only called with certain arguments; but that's ok. Thanks for looking at this... will be in 7.51-1.