Bug 1199918 - lvm module: install additional files needed for LVM system id support
Summary: lvm module: install additional files needed for LVM system id support
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: dracut
Version: 23
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Harald Hoyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-09 09:33 UTC by Peter Rajnoha
Modified: 2016-12-20 13:20 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-12-20 13:20:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch for dracut lvm module to install files needed for LVM system id support (1.25 KB, patch)
2015-03-09 09:33 UTC, Peter Rajnoha
no flags Details | Diff
Patch for dracut lvm module to install files needed for LVM system id support (1.18 KB, patch)
2015-03-09 13:32 UTC, Peter Rajnoha
no flags Details | Diff
Patch for dracut lvm module to install files needed for LVM system id support (2.23 KB, patch)
2015-03-09 14:38 UTC, Peter Rajnoha
no flags Details | Diff

Description Peter Rajnoha 2015-03-09 09:33:22 UTC
Created attachment 999463 [details]
Patch for dracut lvm module to install files needed for LVM system id support

The LVM system id support is recent addition to LVM. See 
https://git.fedorahosted.org/cgit/lvm2.git/tree/man/lvmsystemid.7.in for more information (since lvm v2.02.117, currently the configuration is ignored, but we will enable it soon in next release).

Currently, there are two extra files that may be needed for this system id support. Based on configuration, it's either:

  - /etc/lvm/lvmlocal.conf (if global/system_id_source=lvmlocal is used)

  - or "path_to_file" (if global/system_id_source="file" and global/system_id_file="path_to_file" is used)

Dracut should install these files in addition to lvm.conf for proper LVM systemd ID support.

Comment 1 Peter Rajnoha 2015-03-09 09:39:49 UTC
There's also an option to use /etc/machine-id as system_id source. I've noticed the machine-id is already installed in initramfs. Harald, just to make sure - the machine-id is always there in the initramfs now if machine-id is also present on root fs, right? If that's the case, we don't need to do any extra checks for it then...

Comment 2 Harald Hoyer 2015-03-09 12:06:35 UTC
Yes, machine-id is there.

Comment 3 Peter Rajnoha 2015-03-09 13:24:13 UTC
OK, so the patch attached is all we need then...

Comment 4 Peter Rajnoha 2015-03-09 13:32:36 UTC
Created attachment 999527 [details]
Patch for dracut lvm module to install files needed for LVM system id support

Comment 5 Peter Rajnoha 2015-03-09 13:37:12 UTC
Well, I think we can make the lvm.conf copy better - we have improved the lvm dumpconfig, so we can avoid using "sed" to replace settings. I'll provide a better patch in a while...

Comment 6 Peter Rajnoha 2015-03-09 14:38:52 UTC
Created attachment 999568 [details]
Patch for dracut lvm module to install files needed for LVM system id support

This patch also includes lvm dumpconfig --mergedconfig call which simplifies configuration handling a bit. I still kept the old code though as a fallback. But if we are sure this won't run with LVM older than 2.2.99 (e.g. on RHEL), we could simply rely on lvm dumpconfig --mergeconfig. But let's keep the fallback for safety.

Comment 7 Harald Hoyer 2015-03-16 10:56:55 UTC
commit dea0634544fc8e8ca4c93e0550f9a1416a82b29c

Comment 8 Jan Kurik 2015-07-15 14:25:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 9 Mike McCune 2016-03-28 22:40:27 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 10 Fedora End Of Life 2016-11-24 11:32:47 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 11 Fedora End Of Life 2016-12-20 13:20:54 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.