Bug 1200321 - Review Request: rubygem-fog-atmos - Module for the 'fog' gem to support Atmos
Summary: Review Request: rubygem-fog-atmos - Module for the 'fog' gem to support Atmos
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1200310
Blocks: 1152158
TreeView+ depends on / blocked
 
Reported: 2015-03-10 10:02 UTC by Vít Ondruch
Modified: 2016-01-04 05:54 UTC (History)
3 users (show)

Fixed In Version: rubygem-fog-atmos-0.1.0-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-19 08:34:53 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2015-03-10 10:02:12 UTC
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-fog-atmos.git/tree/rubygem-fog-atmos.spec?id=6e1e7b211d625fabb04c2ab6702eac58601e04fd
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-atmos-0.1.0-1.fc23.src.rpm
Description: This library can be used as a module for `fog` or as standalone provider to use the Atmos in applications.
Fedora Account System Username: vondruch

Comment 1 Vít Ondruch 2015-03-11 12:18:41 UTC
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9203757

Comment 2 Josef Stribny 2015-03-13 07:18:31 UTC
Taking.

Comment 3 Josef Stribny 2015-03-13 07:27:45 UTC
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/rubygem-fog-atmos-0.1.0-1.fc23.noarch.rpm rubygem-fog-atmos.noarch: W: no-documentation
rubygem-fog-atmos.noarch: E: zero-length /usr/share/gems/gems/fog-atmos-0.1.0/lib/fog/atmos/storage.rb
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

lib/fog/atmos/storage.rb file should be most likely deleted upstream.

See https://github.com/fog/fog-atmos/commit/4e502a05d26bd9e8e3f0a718063a99e746b99923

Otherwise the package builds, installs and runs. Spec is alright and tests are passing => APPROVED.

Comment 4 Vít Ondruch 2015-03-13 09:26:50 UTC
(In reply to Josef Stribny from comment #3)
> $ rpmlint
> /var/lib/mock/fedora-rawhide-x86_64/result/rubygem-fog-atmos-0.1.0-1.fc23.
> noarch.rpm rubygem-fog-atmos.noarch: W: no-documentation
> rubygem-fog-atmos.noarch: E: zero-length
> /usr/share/gems/gems/fog-atmos-0.1.0/lib/fog/atmos/storage.rb
> 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
> 
> lib/fog/atmos/storage.rb file should be most likely deleted upstream.
> 
> See
> https://github.com/fog/fog-atmos/commit/
> 4e502a05d26bd9e8e3f0a718063a99e746b99923

I know about this file. Actually there is plenty of those in other fog adapters. Not sure if they should really be removed. Actually, since these files looks like some plugins, I think that they were left there for backward compatibility. Will see what upstream thinks about it:

https://github.com/fog/fog-atmos/issues/3

Otherwise thanks for the reviews.

New Package SCM Request
=======================
Package Name: rubygem-fog-atmos
Short Description: Module for the 'fog' gem to support Atmos
Upstream URL: https://github.com/fog/fog-atmos
Owners: vondruch
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2015-03-13 13:43:17 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.