Bug 120060 - Passwd code cleanup
Passwd code cleanup
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: passwd (Show other bugs)
rawhide
All Linux
medium Severity high
: ---
: ---
Assigned To: Jindrich Novy
Mike McLean
:
Depends On:
Blocks: FC2Target FC3Target
  Show dependency treegraph
 
Reported: 2004-04-05 13:50 EDT by Steve Grubb
Modified: 2013-07-02 18:59 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-09-02 07:46:17 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch that fixes bugs found by code review. (2.83 KB, patch)
2004-04-05 13:52 EDT, Steve Grubb
no flags Details | Diff
Revised patch (2.51 KB, patch)
2004-05-03 11:10 EDT, Steve Grubb
no flags Details | Diff

  None (edit)
Description Steve Grubb 2004-04-05 13:50:44 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4.2)
Gecko/20040308

Description of problem:
During a code review, I found several issues with the programs in the
passwd rpm. Notibly, the passwd program has an off by 1 in the case of
--stdin. buffer is 80, len passed to read is 79, location 78 is 0'ed.
This is more noticeable if you imagine i == 1 after read. Also, if
read returns an error, the program continues as if nothing bad
happened and tries to zero buffer[-2];

Also, pam_start was not being checked for its return code.

Various minor memory leaks.

Version-Release number of selected component (if applicable):
passwd-0.68

How reproducible:
Always

Steps to Reproduce:
Found during code review.
    

Additional info:

I will attach a patch that fixes these. I did not look at prior
versions to see if these issues exist.
Comment 1 Steve Grubb 2004-04-05 13:52:41 EDT
Created attachment 99118 [details]
Patch that fixes bugs found by code review.

Please apply before releasing fedora core 2.
Comment 2 Steve Grubb 2004-05-03 11:10:06 EDT
Created attachment 99912 [details]
Revised patch

The off by one problem was found to be used to remove the \n. Therefore the
patch needed updating. Please use this one instead.
Comment 3 Alan Cox 2004-07-27 16:25:29 EDT
Note btw that there is a small behavioour change if the user uses ^V
before newl ine characters. The new behaviour seems somewhat wiser
however.

Comment 4 Steve Grubb 2004-07-27 17:15:42 EDT
At one point, I had:

 if (i && newPassword[i-1] == '\n')
    newPassword[i-1] = 0;

It was suggested on vend-sec to just do a strchr instead. I suppose
they may have meant strrchr.
Comment 5 Jindrich Novy 2004-09-02 07:46:17 EDT
Hello Steve, most things from your patch were applied.

Thanks,
Jindrich

Note You need to log in before you can comment on or make changes to this bug.