Bug 1200889 - Review Request: lpod-python - a python library implementing the OpenDocument Format standard
Summary: Review Request: lpod-python - a python library implementing the OpenDocument ...
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1200893
TreeView+ depends on / blocked
 
Reported: 2015-03-11 15:15 UTC by David Tardon
Modified: 2019-09-17 15:37 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-17 15:37:33 UTC
Type: ---
Embargoed:
zbyszek: fedora-review?


Attachments (Terms of Use)

Description David Tardon 2015-03-11 15:15:51 UTC
Spec URL: https://dtardon.fedorapeople.org/rpm/lpod-python.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/lpod-python-1.1.5-1.fc22.src.rpm
Description: lpod-python is the python implementation of the lpOD Project (Languages & Platforms OpenDocument, definition of a Free Software API implementing the ISO/IEC 26300 standard).
Fedora Account System Username: dtardon

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-07-30 15:41:11 UTC
Name should be python-lpod according to the guidelines [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29].

Add Provides: python2-lpod = %{version}-%{release}

Use %license macro for the license files.

What about python3 support?

Looks fine.

Comment 2 David Tardon 2015-07-31 08:30:33 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Name should be python-lpod according to the guidelines
> [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.
> 28python_modules.29].

On the other side, the guidelines for python3 only require that "all python3 modules MUST have python3 in their name." Are the rules stricter for python2?

Also note that this is only the source name. The rpms it builds are named python-*.

> Add Provides: python2-lpod = %{version}-%{release}

Okay.

> Use %license macro for the license files.

Okay.

> What about python3 support?

Possibly.

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-07-31 12:59:58 UTC
I'd find it a gratuitous source of confusion to have python-lpod built from lpod-python. lpod-python would normally be used for a python subpackage built off a main package. You are right that the guidelines do not explicitly specify that either version is correct. So it's your choice.

>> What about python3 support?
> Possibly.
Oh, I looked at the sources now. They don't seem python3 compatible at all.
So the point is moot for now.

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-03-05 22:31:08 UTC
Any plans to continue with this?

Comment 5 Zbigniew Jędrzejewski-Szmek 2019-09-17 15:37:33 UTC
Let's close this. Feel free to restart the process at any time.


Note You need to log in before you can comment on or make changes to this bug.