Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-1.0.0-1.fc21.src.rpm Project URL: https://github.com/ampledata/pygatt Description: This Module allows reading and writing to GATT descriptors on devices such as fitness trackers, sensors, and anything implementing standard GATT Descriptor behavior. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9208120 rpmlint output: [fab@laptop017 SRPMS]$ rpmlint python*-pygatt* python-pygatt.src: W: spelling-error %description -l en_US gatttool -> tattoo 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [fab@laptop017 noarch]$ rpmlint python*-pygatt* python3-pygatt.noarch: W: spelling-error %description -l en_US gatttool -> tattoo python-pygatt.noarch: W: spelling-error %description -l en_US gatttool -> tattoo 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab
%changelog * Wed Jun 03 2015 Fabian Affolter <mail> - 1.0.1-1 - Update to latest upstream release 1.0.1 Update files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-1.0.1-1.fc21.src.rpm
So, the packaging is OK, but it looks like it can be simplified a lot. Have you tried running %build and %install without creating a separate py3k directory? This package doesn't use 2to3 so this should work just as well. You can use %global _docdir_fmt %{name} to use a common license and documentation directories. %if 0%{?fedora} > 12 → %if 0%{?fedora}
Good job in the spec But there is some updates here: https://fedoraproject.org/wiki/Packaging:Python Now you must add a Provide: python2-foo and and build a subpackage for python 2 and 3 Please update the spec and I will run the review.
Hi, do want to continue with this review?
Sorry, forgot about that package.
%changelog * Thu Nov 17 2016 Fabian Affolter <mail> - 3.0.0-2 - Update to latest Python guidelines * Fri Sep 16 2016 Fabian Affolter <mail> - 2.1.0-1 - Update to latest upstream release 2.1.0 * Tue Mar 22 2016 Fabian Affolter <mail> - 2.0.1-1 - Update py3 - Update to latest upstream release 2.0.1 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-3.0.0-1.fc24.src.rpm
No need to define %sum, just fill in the first Summary, and then use %summary in subsequent ones. Requries: bluez should apply to both subpackages, no? The tarball contains some pdf files which don't look like they're redistributable. You'll have to provide a sanitized tarball without them.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > No need to define %sum, just fill in the first Summary, and then use > %summary in subsequent ones. There are several ways to do. > Requries: bluez should apply to both subpackages, no? Updated > The tarball contains some pdf files which don't look like they're > redistributable. You'll have to provide a sanitized tarball without them. Switched to the tarball from PyPI. That one doesn't contain the PDF files. %changelog * Tue Jan 17 2017 Fabian Affolter <mail> - 3.0.0-2 - Change source URL - Update requirements Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-3.0.0-2.fc24.src.rpm
+ package name follows the guidelines + summary and description are legible + license is acceptable (ASL 2.0) + license is specified correctly + latest python packaging template is used + %python_provide are present + provides/requires/br seem correct rpmlint: one bogus spelling error and many bogus python-bytecode-wrong-magic-value errors Package is APPROVED.
Thanks for the review.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pygatt
python-pygatt-3.0.0-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a18da77a3c
python-pygatt-3.0.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6427f18cfd
python-pygatt-3.0.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6427f18cfd
python-pygatt-3.0.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a18da77a3c
python-pygatt-3.0.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-pygatt-3.0.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
And don't worry about crappy clips that turn you off in seconds. We're talking high-quality, crisp HD goodness that makes you feel like you're right there getting in on the action. Perfect skin details, vivid colors... it's like Bollywood but much hotter and without any censors. https://indianporn.love/videos/72335/cum-eating-cuckold-compilation-with-a-entire/ https://hotdesiporn.com/videos/ananya-nude-show-to-boss/ https://desiporn.site/videos/63350/amazing-xxx-sexy-fucking-with-friend-s-sexy-milf/