Bug 1201206 - Fix spec file so it builds for epel7
Summary: Fix spec file so it builds for epel7
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sniproxy
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nikos Mavrogiannopoulos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-12 10:25 UTC by Robin Bowes
Modified: 2015-04-01 01:57 UTC (History)
2 users (show)

Fixed In Version: sniproxy-0.3.4-3.el7
Clone Of:
Environment:
Last Closed: 2015-04-01 01:57:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch to fix build on EL (343 bytes, patch)
2015-03-12 10:25 UTC, Robin Bowes
no flags Details | Diff

Description Robin Bowes 2015-03-12 10:25:48 UTC
Created attachment 1000904 [details]
patch to fix build on EL

As this package is not (yet?) in epel, I'm re-building the Fedora package for epel7 using mock. The build fails because the perl module Time::HiRes is not installed by default on EL7 and this module is required by the sniproxy tests.

This is with version 0.3.4-2

To re-produce (on an EL7 host):

rpm -ivh sniproxy-0.3.4-2.fc21.src.rpm
rpmbuild -bs ~/rpmbuild/SPECS/sniproxy.spec
mock -r epel-7-x86_64 ~/rpmbuild/SRPMS/sniproxy-0.3.4-2.el7.centos.src.rpm

The build fails because the tests fail due to the missing perl module.

The build should complete successfully.

I've attached a patch that fixes the problem.

Comment 1 Fedora Update System 2015-03-12 10:46:06 UTC
sniproxy-0.3.4-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/sniproxy-0.3.4-3.el7

Comment 2 Nikos Mavrogiannopoulos 2015-03-12 10:46:39 UTC
Thanks, I've submitted a build for epel7.

Comment 3 Robin Bowes 2015-03-12 10:49:15 UTC
Thanks. Also, any chance of a version bump? Latest release is 0.3.6

Comment 4 Nikos Mavrogiannopoulos 2015-03-12 11:59:56 UTC
I've put in master to be included in F22. Do you think there are bugs requiring the backport to f21 and epel7?

Comment 5 Robin Bowes 2015-03-12 12:45:32 UTC
There are a few of things that I'd like to see in EPEL7, specifically:

 - logrotate script
 - man page
 - config reload on SIGHUP (systemd unit file could be modified to take advantage of this)

R.

Comment 6 Nikos Mavrogiannopoulos 2015-03-12 12:50:07 UTC
Do you want to become co-maintainer and handle the epel7 branch?

Comment 7 Robin Bowes 2015-03-13 13:25:54 UTC
I would be happy to do that - I might need some hand-holding to start with, but yeah, why not?!

R.

Comment 8 Nikos Mavrogiannopoulos 2015-03-13 14:20:09 UTC
Ok. For start you'll need to get an account and apply for access at:
https://admin.fedoraproject.org/pkgdb/package/sniproxy/

(apply for master and epel7)

The important links are:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
https://fedoraproject.org/wiki/Packaging:Guidelines

(fedora guidelines apply for epel as well)

Let me know if anything is not clear.

Comment 9 Fedora Update System 2015-03-13 15:44:14 UTC
Package sniproxy-0.3.4-3.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing sniproxy-0.3.4-3.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-1245/sniproxy-0.3.4-3.el7
then log in and leave karma (feedback).

Comment 10 Robin Bowes 2015-03-13 23:42:01 UTC
(In reply to Nikos Mavrogiannopoulos from comment #8)
> Ok. For start you'll need to get an account and apply for access at:
> https://admin.fedoraproject.org/pkgdb/package/sniproxy/
> 
> (apply for master and epel7)
> 
> The important links are:
> https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
> https://fedoraproject.org/wiki/Packaging:Guidelines
> 
> (fedora guidelines apply for epel as well)
> 
> Let me know if anything is not clear.

OK, I've created my Fedora account.

I think I now need to get sponsorship to become a packager, as per https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer

Are you s sponsor? If you're not, I can probably find someone to sponsor me.

Let me know...

R.

Comment 11 Robin Bowes 2015-03-14 00:02:46 UTC
BTW, since me previous comment (#5) I've discovered that one of the features I need to use is not available in 0.3.4, specifically I want to be able to specific a local caching name server in the sniproxy config. This was added in https://github.com/dlundquist/sniproxy/commit/0e2f102a71b475ba97ac367d2c1ef8cd4a14f6eb

I will chase the upstream author regarding making a new release.

I'd also like to get our RPM packaging code merge back upstream so it's possible to do a Fedora/RedHat-compatible build from the git repo.

R.

Comment 12 Ken Dreyer 2015-03-14 00:29:58 UTC
Hi Nikos, Robin reached out in #epel today to find a sponsor.

I'm happy to proxy sponsor him if you'll agree to mentor him, per https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer

Will that work for you?

Comment 13 Robin Bowes 2015-03-14 00:34:19 UTC
My FAS account ID is: yo61

Comment 14 Nikos Mavrogiannopoulos 2015-03-14 10:30:12 UTC
(In reply to Ken Dreyer from comment #12)
> Hi Nikos, Robin reached out in #epel today to find a sponsor.
> 
> I'm happy to proxy sponsor him if you'll agree to mentor him, per
> https://fedoraproject.org/wiki/
> How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer
> 
> Will that work for you?

yes

Comment 15 Ken Dreyer 2015-03-14 12:48:32 UTC
Thanks Nikos! I've sponsored Robin (yo61) into the packagers group today.

Robin, please feel free to request ACLs on the epel7 branch in pkgdb.

Comment 16 Fedora Update System 2015-04-01 01:57:14 UTC
sniproxy-0.3.4-3.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.