Bug 1201380
| Summary: | Proxy client receives Internal Server Error if Proxy's authentication token has expired | ||
|---|---|---|---|
| Product: | [Community] Spacewalk | Reporter: | Stephen Herr <sherr> |
| Component: | Proxy Server | Assignee: | Stephen Herr <sherr> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Satellite QA List <satqe-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 2.2 | CC: | aathomas, cperry, redhat, rvdwees, satqe-list, tpapaioa, xdmoon |
| Target Milestone: | --- | Keywords: | Regression |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | spacewalk-proxy-2.3.13-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1188868 | Environment: | |
| Last Closed: | 2015-04-14 19:03:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1188868 | ||
| Bug Blocks: | 465198, 1127217, 1207293 | ||
|
Description
Stephen Herr
2015-03-12 15:31:48 UTC
Cloning for Spacewalk, as this is also a problem for Proxy 2.2 -> Spacewalk 2.2. So I have no idea what changed to make this start occurring, it may have been so basic as to be an implementation detail change inside of mod_wsgi. The base problem is that the wsgi.Input object that mod_wsgi hands us that contains the body of the client's request is only guaranteed to be readable once, and in the case of an expired auth token we need to read it twice: once to copy it into the first request we send to Spacewalk (which gets denied because of expired auth token), and a second time when we repeat the request with a valid auth token. To fix I am replacing the wsgi.Input stream with a SmartIO object (wrapper around StringIO), which can be read as many times as we need. Committing to Spacewalk master: e9be1343f4aad6d8f2a880313aa21773816cb7e0 And a checkstyle fix: 82e50bff83198ee2748f1a077f9a5e0b1522538c Moving bugs to ON_QA as we move to release Spacewalk 2.3 *** Bug 1025891 has been marked as a duplicate of this bug. *** Spacewalk 2.3 has been released. See https://fedorahosted.org/spacewalk/wiki/ReleaseNotes23 |