Bug 1202274 - Minor improvements and code cleanup for libgfapi
Summary: Minor improvements and code cleanup for libgfapi
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-16 09:37 UTC by Niels de Vos
Modified: 2018-08-29 03:36 UTC (History)
3 users (show)

Fixed In Version: glusterfs-4.1.3 (or later)
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-29 03:36:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2015-03-16 09:37:14 UTC
Use this bug to file changes that affect libgfapi. Real bugs (problem reports) should have their own bugzilla entry for related patches.

Acceptable changes include:

- improve readability
- minor changes like checking for potential/unlikely NULL dereferences
- cleanup and better error reporting
- ...

Comment 1 Anand Avati 2015-04-24 12:26:20 UTC
REVIEW: http://review.gluster.org/10364 (gfapi: Reduce the log-level from ERROR to TRACE) posted (#2) for review on master by Anoop C S (achiraya)

Comment 2 Anand Avati 2015-04-25 05:26:29 UTC
COMMIT: http://review.gluster.org/10364 committed in master by Vijay Bellur (vbellur) 
------
commit 1b309fd9f80a84f1ccde59dca4a4362213e70f7f
Author: Anoop C S <achiraya>
Date:   Fri Apr 24 17:32:18 2015 +0530

    gfapi: Reduce the log-level from ERROR to TRACE
    
    Change-Id: I0b87f8ccc755a32ac64547c5f5973ea5c468018f
    BUG: 1202274
    Signed-off-by: Anoop C S <achiraya>
    Reviewed-on: http://review.gluster.org/10364
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System

Comment 3 Anand Avati 2015-07-10 13:55:58 UTC
REVIEW: http://review.gluster.org/11623 (gfapi: correct symbol versioning in glfs-handles.h) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 4 Vijay Bellur 2015-11-27 05:31:07 UTC
REVIEW: http://review.gluster.org/12770 (gfapi: Remove TODO for merging of locks) posted (#1) for review on master by Anoop C S (anoopcs)

Comment 5 Vijay Bellur 2016-02-04 21:45:51 UTC
COMMIT: http://review.gluster.org/12770 committed in master by Niels de Vos (ndevos) 
------
commit f6c5024eb3f37b2c4e5a3bea5136987affb19aa7
Author: Anoop C S <anoopcs>
Date:   Fri Nov 27 10:50:14 2015 +0530

    gfapi: Remove TODO for merging of locks
    
    pub_glfs_posix_lock() currently merge/split locks via
    fd_lk_insert_and_merge(). So removing the same from
    TODO list.
    
    Change-Id: I956fbb3a99ada9616392f934034a94be418195c4
    BUG: 1202274
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/12770
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>

Comment 6 Vijay Bellur 2016-05-10 16:56:05 UTC
COMMIT: http://review.gluster.org/14279 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 3887804d5c477de889b9f1c478be3294d9e852fd
Author: Niels de Vos <ndevos>
Date:   Mon May 9 09:49:01 2016 +0200

    gfapi: fix compile warning on 32-bit systems
    
    While compiling gfapi on a 32-bit system, I got the following warning:
    
        glfs.c:1114:33: warning: format '%ld' expects argument of type 'long int', but argument 10 has type 'int64_t' [-Wformat=]
                                         gf_msg_trace ("glfs", 0,
                                         ^
    
    Change-Id: Ia910cbd2e1682d54c9ccfbf773c87d29facab7b0
    BUG: 1202274
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/14279
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: soumya k <skoduri>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 7 Vijay Bellur 2016-06-13 10:32:34 UTC
REVIEW: http://review.gluster.org/14709 (api: Fix a typo in gfapi logging message framework) posted (#1) for review on master by Anoop C S (anoopcs)

Comment 8 Vijay Bellur 2016-06-14 13:08:05 UTC
COMMIT: http://review.gluster.org/14709 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 352758e2f2548a5a66186e8b3179b1e3ee11984c
Author: Anoop C S <anoopcs>
Date:   Mon Jun 13 15:55:39 2016 +0530

    api: Fix a typo in gfapi logging message framework
    
    Change-Id: I8a44a37a73f0c92783aecac8187247db98957070
    BUG: 1202274
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/14709
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 9 Worker Ant 2016-12-12 12:04:03 UTC
REVIEW: http://review.gluster.org/16110 (Move glusterfs_ctx_destroy() from gfapi to libglusterfs) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 10 Amar Tumballi 2018-08-29 03:36:07 UTC
This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug.


Note You need to log in before you can comment on or make changes to this bug.