Spec URL: https://rkuska.fedorapeople.org/xonsh.spec SRPM URL: https://rkuska.fedorapeople.org/xonsh-0.1.2-1.fc22.src.rpm Description: xonsh is a Python-ish, BASHwards-compatible shell language and command prompt. The language is a superset of Python 3.4 with additional shell primitives. xonsh (pronounced *conch*) is meant for the daily use of experts and novices alike. Fedora Account System Username: rkuska
I'll take this.
Just a note for myself, github repo contains tests, I should add them.
* Rpmlint output seems to be alright. * According to https://fedoraproject.org/wiki/Packaging:LicensingGuidelines, Text of the license for the package must be included in %license. If the source package does not include the text of the license, the packager should contact upstream and encourage them to correct this mistake.
After watching the xonsh talk at PyCon this week, I'd be happy to take this package over. https://lmacken.fedorapeople.org/rpms/xonsh-0.3.2-1.fc23.src.rpm https://lmacken.fedorapeople.org/rpms/xonsh.spec * Fri Jun 03 2016 Luke Macken <lmacken> - 0.3.2-1 - Latest upstream release - Update the Summary
A few rpmlint issues: xonsh.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/xonsh/xoreutils/_which.py 644 /usr/bin/env xonsh.noarch: E: script-without-shebang /usr/lib/python3.4/site-packages/xontrib/pyselect.xsh xonsh.noarch: W: no-manual-page-for-binary xonsh Also, the separate spec file is different from that in the srpm: [jdulaney@bodrog review]$ diff -u xonsh.spec ../rpmbuild/SPECS/xonsh.spec --- xonsh.spec 2016-06-04 21:25:06.000000000 +0000 +++ ../rpmbuild/SPECS/xonsh.spec 2016-06-04 21:08:36.000000000 +0000 @@ -9,6 +9,9 @@ License: BSD URL: https://github.com/scopatz/xonsh Source0: https://pypi.python.org/packages/source/x/%{pypi_name}/%{pypi_name}-%{version}.tar.gz +# It may look nice but the logo is just redudant spam +# in build process +#Patch0: 001-remove-logo-from-setup.patch BuildArch: noarch BuildRequires: python3-devel You may want to change the url to the new pypi.io. Also, not sure if we should consider the old review abandoned or not; if so, I think the procedure is to close this one and start a fresh review.
(In reply to John Dulaney from comment #6) > A few rpmlint issues: > > xonsh.noarch: E: non-executable-script > /usr/lib/python3.4/site-packages/xonsh/xoreutils/_which.py 644 /usr/bin/env > xonsh.noarch: E: script-without-shebang > /usr/lib/python3.4/site-packages/xontrib/pyselect.xsh > xonsh.noarch: W: no-manual-page-for-binary xonsh > > > Also, the separate spec file is different from that in the srpm: > > [jdulaney@bodrog review]$ diff -u xonsh.spec ../rpmbuild/SPECS/xonsh.spec > --- xonsh.spec 2016-06-04 21:25:06.000000000 +0000 > +++ ../rpmbuild/SPECS/xonsh.spec 2016-06-04 21:08:36.000000000 +0000 > @@ -9,6 +9,9 @@ > License: BSD > URL: https://github.com/scopatz/xonsh > Source0: > https://pypi.python.org/packages/source/x/%{pypi_name}/%{pypi_name}- > %{version}.tar.gz > +# It may look nice but the logo is just redudant spam > +# in build process > +#Patch0: 001-remove-logo-from-setup.patch > BuildArch: noarch > > BuildRequires: python3-devel > > You may want to change the url to the new pypi.io. > > > > Also, not sure if we should consider the old review abandoned or not; if so, > I think the procedure is to close this one and start a fresh review. Updated: https://lmacken.fedorapeople.org/rpms/xonsh-0.3.2-1.fc23.src.rpm https://lmacken.fedorapeople.org/rpms/xonsh.spec
rpmlint: xonsh.noarch: W: no-manual-page-for-binary xonsh Looking good now. Do you want to close this review out and do a fresh one?
As this appears abandoned, new review is at 1342851. *** This bug has been marked as a duplicate of bug 1342851 ***