Created attachment 1002241 [details] engine-logs Description of problem: I tested this bug https://bugzilla.redhat.com/show_bug.cgi?id=1197616 Now it clean all task from command_entites table and upgrading to vt13.15 from av14.3 is successful, but after upgrade, the VM is still locked forever.. in tab Tasks in webadmin is only "[No jobs available]" Version-Release number of selected component (if applicable): upgrade from av14.3 to vt13.15 How reproducible: 100% Steps to Reproduce: 1. Start a template creation on av14.3 2. Stop the engine 3. Upgrade to vt13.15 Actual results: VM is still locked Expected results: VM should be unlocked Additional info: Attached log from engine
Eli, what should free the lock?
(In reply to Oved Ourfali from comment #1) > Eli, what should free the lock? I an not sure if engine-setup calls the unlock_entity.sh utility, but at least unlock_entity.sh can be called manually to release the lock. Didi, does engine-setup suggests cleaning of locked entities using unlock_entity.sh ???
No, engine-setup doesn't call unlock_entity.sh at all. Should we explicitly unlock everything locked on each upgrade?
(In reply to Simone Tiraboschi from comment #3) > No, engine-setup doesn't call unlock_entity.sh at all. > > Should we explicitly unlock everything locked on each upgrade? I think that we should run in engine-setup at least unlock_entity.sh -q this should return a list of locked entities If the list is not empty, IMO , engine-setup should suggest unlocking of those entities
On my opinion it would be much better if entity got unlocked on task completion/deletion. If task_cleaner.sh removed a task cause it detected that it would never ended (zombie), why should we keep the corresponding entity locked if no task need to keep it locked anymore?
(In reply to Simone Tiraboschi from comment #5) > On my opinion it would be much better if entity got unlocked on task > completion/deletion. > If task_cleaner.sh removed a task cause it detected that it would never > ended (zombie), why should we keep the corresponding entity locked if no > task need to keep it locked anymore? We don't have this info at a task level. I agree with Eli that it should run on setup, as it would help overcome others issues that customers might experience due to various issues. In my opinion no object should be locked after upgrade. The task deletion is NY user approval? If so, I'd run unlock as well if it got approved.
Zombie are deleted without asking any confirmation prior to other check, than we ask if he want to wait for other running task and if he respond no we abort. We need to delete zombies before start waiting otherwise we will wait forever. Could I call unlock_entity.sh to unlock everything in a single shot at the end of the upgrade procedure?
(In reply to Simone Tiraboschi from comment #7) > Zombie are deleted without asking any confirmation prior to other check, > than we ask if he want to wait for other running task and if he respond no > we abort. > > We need to delete zombies before start waiting otherwise we will wait > forever. > > Could I call unlock_entity.sh to unlock everything in a single shot at the > end of the upgrade procedure? I think that it will be the simplest way to go. Eli - can you confirm?
(In reply to Oved Ourfali from comment #8) > (In reply to Simone Tiraboschi from comment #7) > > Zombie are deleted without asking any confirmation prior to other check, > > than we ask if he want to wait for other running task and if he respond no > > we abort. > > > > We need to delete zombies before start waiting otherwise we will wait > > forever. > > > > Could I call unlock_entity.sh to unlock everything in a single shot at the > > end of the upgrade procedure? > > I think that it will be the simplest way to go. > Eli - can you confirm? We don't have this ability today but I guess we can extend the utility to cover total cleanup of all entity locks
For a complete solution, this should be called from the engine-setup in order to unlock all locked entities, should I open a separate BZ for that ???
(In reply to Eli Mesika from comment #10) > For a complete solution, this should be called from the engine-setup in > order to unlock all locked entities, should I open a separate BZ for that ??? Yes. Mark it as integration.
Verified in 3.6.0-0.0.master.20150627185750.git6f063c1.el6 update from ovirt 3.5 to 3.6.0-3