Bug 1202373 - BTRFS_BUILD_VERSION not available
Summary: BTRFS_BUILD_VERSION not available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: btrfs-progs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Josef Bacik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-16 13:49 UTC by Lokesh Mandvekar
Modified: 2015-03-30 04:08 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-30 04:08:41 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Lokesh Mandvekar 2015-03-16 13:49:31 UTC 
Description of problem:
The version on rawhide no longer defines the BTRFS_BUILD_VERSION macro. This (possibly among other issues) is causing docker package builds to fail.


Version-Release number of selected component (if applicable): 3.19-1.fc23


Additional info: https://github.com/docker/docker/commit/318b11f62fe0f16a190e85e3cfe5d01432bf92a9#commitcomment-10201703
Comment 1 Eric Sandeen 2015-03-16 15:29:35 UTC 
Why does Docker care if btfs-progs is at v3.18, 3.18.3, or 3.19, or ....?

Anyway, looks like it was explicitly removed upstream as part of the conversion to autotools:

commit 505669320b1d03c9b15fd32b8480e1ca7ac89a58
Author: David Sterba <dsterba>
Date:   Tue Feb 3 15:04:28 2015 +0100

    btrfs-progs: build, fix version macro name
    
    Autoconf changed it to PACKAGE_VERSION and moved to config.h.
    
    Signed-off-by: David Sterba <dsterba>

commit 33f2d6b84da88139b2b7ff53e470cb198d425381
Author: Karel Zak <kzak>
Date:   Tue Dec 9 15:37:03 2014 +0100

    btrfs-progs: autoconf: use standard PACKAGE_* macros
    
    - use standard PACKAGE_{NAME,VERSION,STRING,URL,...} autoconf macros
      rather than homemade BTRFS_BUILD_VERSION

I think the proper solution for Docker is to simply remove BtrfsBuildVersion(); the library version (still in version.h) may matter to Docker, but the package version should not.

If you really need it, please send a note to the upstream btrfs-progs list.
Comment 2 Daniel Walsh 2015-03-16 17:06:34 UTC 
I agree I think we should just remove the BTRFS_BUILD_VERSION.
Comment 3 Lokesh Mandvekar 2015-03-16 17:57:10 UTC 
http://repo.or.cz/w/btrfs-progs-unstable/devel.git/commitdiff/514c5689bd672b21fa8033a7a48eae56a6e36b7f?hp=d531e2ca6743d823d020de735764368abd4996c9 brings back BTRFS_BUILD_VERSION. just that this is useful for 'docker info'. Guessing this will land in stable soon.
Comment 4 Eric Sandeen 2015-03-16 18:57:41 UTC 
kdave did agree that it shouldn't have disappeared from the public header, so was amenable to adding it back.  Thanks for sending the patch, Lokesh.  I'll pick it up on the next upstream release, if that's ok.

-Eric
Comment 5 Daniel Walsh 2015-03-16 19:18:56 UTC 
But will this remain for ever?  Will it continue to be updated?  Does it make any sense to display this in docker?  I sent a patch to docker to remove this code.
Comment 6 Lokesh Mandvekar 2015-03-30 04:08:41 UTC 
BTRFS_BUILD_VERSION is now defined in 3.19.1 and is also available in rawhide.
Note You need to log in before you can comment on or make changes to this bug.