Spec URL: http://people.freedesktop.org/~hughsient/temp/fwupd.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/fwupd-0.1.0-1.fc21.src.rpm KOJI URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=9242731 Description: fwupd is a daemon to allow session software to update device firmware Fedora Account System Username: rhughes $ rpmlint ~/rpmbuild/*RPMS/fwupd-0.1.0* fwupd.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.fwupd.conf 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Taking for review.
Fedora review fwupd-0.1.0-1.fc21.src.rpm 2015-03-16 + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. ! The package meets the Packaging Guidelines Some questions below about systemd macro use. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license ! The license text (COPYING) is included in %license Can you use %license COPYING instead of %doc COPYING please? + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 57e840121eafe4eb5510b9e8de274423 fwupd-0.1.0.tar.xz 57e840121eafe4eb5510b9e8de274423 Download/fwupd-0.1.0.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 According to https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd , should also have: Requires(post): systemd Requires(preun): systemd Requires(postun): systemd ... to make sure rpm orders the transactions so that systemd gets installed before fwupd. Another question is if it should have %systemd_postun or %systemd_postun_with_restart in %post? I don't know the answer to that, but it probably depends on whether it is safe to restart the daemon during package upgrades?
(In reply to Kalev Lember from comment #2) > ! The license text (COPYING) is included in %license > Can you use %license COPYING instead of %doc COPYING please? Fixed, thanks. > Requires(post): systemd > Requires(preun): systemd > Requires(postun): systemd Fixed. > Another question is if it should have %systemd_postun or > %systemd_postun_with_restart in %post? I don't know the answer to that, but > it probably depends on whether it is safe to restart the daemon during > package upgrades? At this stage, systemd_postun_with_restart makes more sense I guess; it's system activated and quit-on-idle so I don't think it matters much each way. New spec here: http://people.freedesktop.org/~hughsient/temp/fwupd.spec Thanks!
Looks good to me, thanks! APPROVED
New Package SCM Request ======================= Package Name: fwupd Short Description: fwupd is a daemon to allow session software to update device firmware Upstream URL: https://github.com/hughsie/fwupd Owners: rhughes Branches: f21 f22 InitialCC: rhughes
Git done (by process-git-requests).
Thanks!