Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1202457 - Referencing a non-existent ACL role should error out more gracefully
Referencing a non-existent ACL role should error out more gracefully
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs (Show other bugs)
7.1
Unspecified Unspecified
medium Severity unspecified
: rc
: ---
Assigned To: Tomas Jelinek
cluster-qe@redhat.com
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-16 12:34 EDT by Radek Steiger
Modified: 2015-11-19 04:36 EST (History)
2 users (show)

See Also:
Fixed In Version: pcs-0.9.140-1.el7
Doc Type: Bug Fix
Doc Text:
Cause: User runs a 'pcs acl user create' or 'pcs acl group create' command and specifies a non-existent acl role in it. Consequence: pcs dumps an invalid CIB to a terminal. Fix: Verify the acl role exists. Result: Pcs informs the user that the acl role does not exist.
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-11-19 04:36:17 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
proposed fix (2.17 KB, patch)
2015-04-17 10:22 EDT, Tomas Jelinek
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2290 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2015-11-19 04:43:53 EST

  None (edit)
Description Radek Steiger 2015-03-16 12:34:08 EDT
> Description of problem:

When a non-existent ACL role is referenced within creating a user/group, pcs errors out with invalid CIB. 

[root@virt-041 ~]# pcs acl user create MyUser TestRole
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
<cib crm_feature_set="3.0.9" validate-with="pacemaker-2.3" epoch="344" num_updates="0" admin_epoch="0" cib-last-written="Mon Mar 16 17:25:35 2015" have-quorum="1" dc-uuid="2">
...

[root@virt-041 ~]# pcs acl group create MyGroup TestRole
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
<cib crm_feature_set="3.0.9" validate-with="pacemaker-2.3" epoch="345" num_updates="0" admin_epoch="0" cib-last-written="Mon Mar 16 17:32:51 2015" have-quorum="1" dc-uuid="2">
...

The relevant ACL part, where role definition is missing:

...
<acls>
  <acl_target id="MyUser">
    <role id="TestRole"/>
  </acl_target>
</acls>
...

We should check if the role exists before adding a user.


> Version-Release number of selected component (if applicable):
pcs-0.9.137-13.el7.x86_64
pacemaker-1.1.12-22.el7.x86_64
Comment 2 Tomas Jelinek 2015-04-17 10:22:50 EDT
Created attachment 1015613 [details]
proposed fix
Comment 4 Tomas Jelinek 2015-06-04 10:48:41 EDT
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs acl
ACLs are disabled, run 'pcs acl enable' to enable

[root@rh71-node1:~]# pcs acl user create MyUser TestRole
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...
[root@rh71-node1:~]# pcs acl group create MyGroup TestRole
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs acl
ACLs are disabled, run 'pcs acl enable' to enable

[root@rh71-node1:~]# pcs acl user create MyUser TestRole
Error: cannot find acl role: TestRole
[root@rh71-node1:~]# echo $?
1
[root@rh71-node1:~]# pcs acl group create MyGroup TestRole
Error: cannot find acl role: TestRole
[root@rh71-node1:~]# echo $?
1
Comment 8 errata-xmlrpc 2015-11-19 04:36:17 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html

Note You need to log in before you can comment on or make changes to this bug.