Description of problem: Current glfs_new is not flexible enough to error out and destroy the struct members or objects initialized just before the error path/condition. This make the structs or objects to continue or left out with partially recorded data and cause crashes/issues later in the code path or in other words, its not the proper way of doing things. Version-Release number of selected component (if applicable): GlusterFS 3.6.2 How reproducible: N/A Steps to Reproduce: N/A Actual results: N/A Expected results: There should be proper error out path in the subjected function. Additional info:
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#9) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#10) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function.) posted (#11) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#12) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#13) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#14) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#15) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#16) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9903 (libgfapi: revamp glfs_new function) posted (#17) for review on master by Humble Devassy Chirammal (humble.devassy)
COMMIT: http://review.gluster.org/9903 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 299f6ce2b17216a6c09d5345139b9a78f7505b24 Author: Humble Devassy Chirammal <hchiramm> Date: Fri Mar 20 18:57:52 2015 +0530 libgfapi: revamp glfs_new function Current glfs_new() function is not flexible enough to error out and destroy the struct members or objects initialized just before the error path/condition. This make the structs or objects to continue or left out with partially recorded data in fs and ctx structs and cause crashes/issues later in the code path. This patch avoid the issue. Change-Id: Ie4514b82b24723a46681cc7832a08870afc0cb28 BUG: 1202492 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/9903 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Poornima G <pgurusid> Reviewed-by: soumya k <skoduri> Reviewed-by: Kaleb KEITHLEY <kkeithle>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user