At this time of writing, rpmgrill-fetch-build is only able to fetch builds from Koji, since it's using a hard coded koji URL. This should be configurable so we can fetch builds from any koji instance.
Dear Peter, I'm halfway in changing this script when I had a closer look into libtaskotron. How applicable would it be to use libtaskotron to provide builds for rpmgrill? I'm thinking of using `runtask` to run rpmgrill, which provides rpmgrill with the necessary builds, but does not report back to resultsdb or bodhi, but exits with 1 if the task (rpmgrill) failed. This seems to be not supported by taskotron at this point in time. I've started a thread on qa-devel here: https://lists.fedoraproject.org/pipermail/qa-devel/2015-March/001171.html in order to find out.
I think using some taskotron part to interface with brew/koji would be applicable. I'm not familiar with taskotron 'runtask' though. As long as it is (along with the dependencies) possible to run it in RHEL6, we are fine with it.
Also, we would not really need to return RC 1 if rpmgrill found some FAILs: we'll parse the result json anyways. I think it might be useful to somehow distinguish the cases when rpmgrill itself fails (=buggy rpmgrill) from rpmgrill finding fails (=buggy rpms under test)
Dear Petr, I'll check if we can run it on RHEL6. If it works fine, I'll setup a small how to on our github wiki maybe or stick it in the repository on how to run libtaskatron with rpmgrill. In regards to the exit code, I'm not sure if it doesn't matter that much. Reason why I thought it would be good is the fact that it distinguishes the: all good from, there is a failure similar. This behaviour is - I thought - consistent among test runners and other static analysis tools. Most of them allow it to be configurable (e.g. --make-warnings-fatal or something like that.)
It's true that most of test runners and static analysers I've met indeed behaved in this way, right.
Looking into building libtaskotron for RHEL6 seems more effort than just rebuilding it. It will eat quite some time if it's possible. I'll created Bug 1207954 to track my efforts. For the short time I think I'll have to fix up the fetch-build script.
Patch set is up on GerritHub: https://review.gerrithub.io/#/c/229906/
Moving this item to VERIFIED, since we agreed with our QE not to bother with rpmgrill at this point.
Has been released with the 0.28-1 release of rpmgrill available in Fedora and RHEL: * http://koji.fedoraproject.org/koji/taskinfo?taskID=9770113 (Fedora 20) * http://koji.fedoraproject.org/koji/taskinfo?taskID=9770184 (Fedora 21) * http://koji.fedoraproject.org/koji/taskinfo?taskID=9770203 (Fedora 22) * https://brewweb.devel.redhat.com/taskinfo?taskID=9101527 (RHEL 7)
rpmgrill-0.28-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b6d82f473
rpmgrill-0.28-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b6d82f473
meiying, see comment #11, can you help to take a look at this bug still persist in rpmgrill-0.28-1.fc24? thanks.
rpmgrill-0.28-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3b7e4bbb1
rpmgrill-0.28-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3b7e4bbb1
rpmgrill-0.28-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
rpmgrill-0.28-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Hi Roman, Thanks for your efforts for RPMGrill, :) And sorry for my late verification. I had tested on F23 with build which-2.19-5.el6 $ NVR=which-2.19-5.el6 $ rpmgrill-fetch-build $NVR my-$NVR --server-url http://brewhub.engineering.redhat.com/brewhub --top-url https://brewweb.engineering.redhat.com/brew/ I found there is no way to get source rpm package from brew server, is it right or a bug?
Hi Roman, I have designed one test case for this bug, could you have a look? Thanks. https://tcms.engineering.redhat.com/case/532282/?from_plan=18809
Verified it with builds: rpmgrill-0.28-1.fc23 rpmgrill-0.28-1.fc24 Steps to verify it: https://tcms.engineering.redhat.com/case/532282/?from_plan=18809 Because there is another bug 1357314 against fetch build, but will verify this one.
I'm finally closing this one.