Bug 1203587 - Review Request: compat-wxGTK3-gtk2 - GTK2 port of the wxWidgets GUI library
Summary: Review Request: compat-wxGTK3-gtk2 - GTK2 port of the wxWidgets GUI library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-19 08:23 UTC by Lubomir Rintel
Modified: 2015-03-21 11:57 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-21 11:57:23 UTC
Type: Bug
Embargoed:
mmahut: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2015-03-19 08:23:41 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/compat-wxGTK3-gtk2.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/compat-wxGTK3-gtk2-3.0.2-3.1.fc23.src.rpm

Description:

wxWidgets is the GTK port of the C++ cross-platform wxWidgets
GUI library, offering classes for all common GUI controls as well as a
comprehensive set of helper classes for most common application tasks,
ranging from networking to HTML display and image manipulation.

This is a version linked with old GTK version for compatibility with
programs that don't work with more recent GTK yet.

Comment 1 Lubomir Rintel 2015-03-19 08:26:52 UTC
This is based off the wxGTK3 package, the wxGTK3 maintainer didn't object.

The incentive is to make KiCAD works reasonably well again. Once KiCAD (or wxGTK) catches up this package will be put to rest.

I've made an effort to avoid any conflicts with wxGTK3, nothing provided by this package clashes with the main one and it can not be used by accident -- the users of this (just KiCAD) will need to be patched to use wx-config-3.0-gtk2 instead of wx-config-3.0 or wx-config when looking for the wxWidgets library.

Comment 2 Lubomir Rintel 2015-03-19 08:29:41 UTC
Koji build (uses marginally different SPEC, made whitespace changes since): http://koji.fedoraproject.org/koji/taskinfo?taskID=9272409

Comment 3 Lubomir Rintel 2015-03-19 10:59:00 UTC
Koji build with this package: http://koji.fedoraproject.org/koji/taskinfo?taskID=9272973

Comment 4 Marek Mahut 2015-03-20 12:29:08 UTC
Looks fine to me, approved.

Comment 5 Lubomir Rintel 2015-03-20 12:32:59 UTC
Thank you!

New Package SCM Request
=======================
Package Name: compat-wxGTK3-gtk2
Short Description: GTK2 port of the wxWidgets GUI library
Upstream URL: http://www.wxwidgets.org/
Owners: lkundrak
Branches: f21 f22 epel7

Comment 6 Gwyn Ciesla 2015-03-20 17:54:19 UTC
Git done (by process-git-requests).

Comment 7 Nicolas Chauvet (kwizart) 2015-03-21 08:58:56 UTC
Thx for this package. Sounds like filezilla is in the same case (rely on wxGTK3 compiled with gtk2 support).

So this makes me wonder if there is really any "distro wide users" for wxGTK3 without gtk2 ? I mean for packages that will always work with non native gtk3 desktop environment ?

Can you submit a buildroot override (until tuesday) so I can build filezilla with this new package ?
Thx

Comment 8 Nicolas Chauvet (kwizart) 2015-03-21 10:45:50 UTC
There is an issue with your modification of the version field given m4/wxwin.m4 mandate it to be numeric only value.

Maybe it would have been easier to maintain an alternate build from the original wxGTK3 package instead of trying to fork to another compat package...

Comment 9 Lubomir Rintel 2015-03-21 11:57:23 UTC
Thanks for review & Git!

(In reply to Nicolas Chauvet (kwizart) from comment #7)
> Thx for this package. Sounds like filezilla is in the same case (rely on
> wxGTK3 compiled with gtk2 support).
> 
> So this makes me wonder if there is really any "distro wide users" for
> wxGTK3 without gtk2 ? I mean for packages that will always work with non
> native gtk3 desktop environment ?
> 
> Can you submit a buildroot override (until tuesday) so I can build filezilla
> with this new package ?
> Thx

Done.

Imported and built.


Note You need to log in before you can comment on or make changes to this bug.