Bug 1204029 - Crashing in F22 Alpha with updates
Summary: Crashing in F22 Alpha with updates
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ibus-bogo
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Truong Anh Tuan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-20 08:10 UTC by Pravin Satpute
Modified: 2015-07-14 08:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-14 08:14:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Vietnamese string generated successfully with ibus-bogo-0.4-6.fc22 (1.28 MB, image/png)
2015-07-14 08:09 UTC, sandeep shedmake
no flags Details

Description Pravin Satpute 2015-03-20 08:10:57 UTC
Description of problem:
Crashing when selected for typing. 


Version-Release number of selected component (if applicable):
ibus-bogo-0.4.4.fc21 (wondering why this is not built for F22)

How reproducible:
Everytime.

Steps to Reproduce:
1. Follow steps in https://fedoraproject.org/wiki/QA:Bogo
2.
3.

Actual results:
Crashing frequently.

Expected results:
Should work fluently

Additional info:
This bug is detected in i18n test day for F22 https://fedoraproject.org/wiki/Test_Day:2015-03-19_i18n

Comment 1 fujiwara 2015-03-24 03:53:34 UTC
__init__() should not be exported.

--- /usr/share/ibus-bogo/ibus_engine/ibus_engine.py.orig
+++ /usr/share/ibus-bogo/ibus_engine/ibus_engine.py
@@ -73,7 +73,7 @@ def is_in_unity_dash():
 class Engine(IBus.Engine):
     __gtype_name__ = 'EngineBoGo'
 
-    def __init__(self, config, abbr_expander):
+    def init_config(self, config, abbr_expander):
         super(Engine, self).__init__()
         logging.info("You are running ibus-bogo")
 
--- /usr/share/ibus-bogo/ibus_engine/main.py.orig
+++ /usr/share/ibus-bogo/ibus_engine/main.py
@@ -93,28 +93,12 @@ class IMApp:
         if engine_name == "bogo":
             dbus_path = "/org/freedesktop/IBus/Engine/%d" % self.engine_count
 
-            # It looks like the GObject's new_with_type constructor also
-            # calls __init__ but without arguments so there will be error
-            # messages like this:
-            #
-            # TypeError: __init__() missing 1 required positional argument
-            #
-            # We will ignore that message by temporarily redirect stderr
-            # to /dev/null
-
-            f = open('/dev/null', 'w')
-            stderr = sys.stderr
-            sys.stderr = f
-
             engine = Engine.new_with_type(GObject.type_from_name("EngineBoGo"),
                                           "bogo-python",
                                           dbus_path,
                                           self.bus.get_connection())
 
-            sys.stderr = stderr
-            f.close()
-
-            Engine.__init__(engine, self.config, self.abbr_expander)
+            Engine.init_config(engine, self.config, self.abbr_expander)
 
             self.engine_count += 1
             return engine

Comment 2 Pravin Satpute 2015-03-26 09:03:54 UTC
Thank you Fujiwara for patch.

Hi Tuan, 

Please let me know if you are planning for this build. Else i can do it for you.

Comment 3 Truong Anh Tuan 2015-03-26 12:21:58 UTC
I am working with upstream developers to fix this issue.

Comment 4 Pravin Satpute 2015-03-26 14:37:06 UTC
Thank you Tuan for an update. :) 
We have beta freeze deadline 31st March. Hope we will an update by that time. Else we have option of patching same.

Comment 5 Fedora Update System 2015-03-31 06:14:38 UTC
ibus-bogo-0.4-6.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/ibus-bogo-0.4-6.fc22

Comment 6 Fedora Update System 2015-04-02 01:44:30 UTC
Package ibus-bogo-0.4-6.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ibus-bogo-0.4-6.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5338/ibus-bogo-0.4-6.fc22
then log in and leave karma (feedback).

Comment 7 sandeep shedmake 2015-07-14 08:09:17 UTC
Created attachment 1051688 [details]
Vietnamese string generated successfully with ibus-bogo-0.4-6.fc22

Tested ibus-bogo-0.4-6.fc22.

As per https://fedoraproject.org/wiki/QA:Bogo required Vietnamese string is generated/rendered with ibus-bogo-0.4-6.fc22 and doesn't crash any-more while typing with ibus-bogo-0.4-6.fc22.


Note You need to log in before you can comment on or make changes to this bug.