Description of problem:
In the controller-puppet template (in /usr/share/openstack-tripleo-heat-templates/puppet/controller-puppet.yaml) you can see that the template accepts the ExtraConfig and controllerExtraConfig parameters, which are passed in from the parent template overcloud-without-mergepy.yaml, but the parameters are not used anywhere. Therefor the nodes don't see the extra config. 


Version-Release number of selected component (if applicable):
openstack-heat-templates-0.0.1-c44365e.el7.centos.noarch
openstack-tripleo-heat-templates-0.8.2.36-g8772095.el7.centos.noarch


How reproducible:
100%


Steps to Reproduce:
1. Pass a value to the ExtraConfig or controllerExtraConfig attributes during heat stack-create or stack-update. See the file /bin/instack-deploy-overcloud to construct the heat command properly. I passed the following value:

-P controllerExtraConfig='{"keystone":{"config": [{"section": "DEFAULT", "values": [{"option": "list_limit", "value": "3"}]}]}}' 


Actual results:
This value doesn't make it to the nodes. To see what made it to the nodes and what didn't check out the file /var/lib/os-collect-config/cfn.json


Expected results:
These attributes should pass the whole way through.


Additional info:
When I fixed that and passed the value to the nodes, I could see the value in /var/lib/os-collect-config/cfn.json so it confirmed that the templates were fixed - but still the parameter didn't have any effect on the conf files, and it was missing from hiera. This probably means another bug in addition to the broken templates... I'm still investigating