Description of problem: Icon for bacula-tray-monitor shows icon for bat not that of the traymonitor which used to display a tape diskette. Version-Release number of selected component (if applicable): Bacula 7.0.5 How reproducible: allways. Steps to Reproduce: 1. Select Applications Menu 2. Select System 3. Look at Bacula Bat Console and Bacula Monitor Actual results: Both display same icon Expected results: Bacula Monitor should not display same icon as Bat. Additional info: The incorrect icon is /usr/share/pixmaps/bacula-tray-monitor.png
Created attachment 1005998 [details] Bacula Tray Monitor icon This original Bacula Tray Monitor icon I have taken from: http://www.bacula.org/git/cgit.cgi/bacula/tree/bacula/src/tray-monitor/generic.xpm?h=Branch-5.0&id=Release-5.2.13 and next I converted the icon to PNG format. I propose to change Tray Monitor icon to this one.
Created attachment 1006463 [details] Spec file patch for new icon I am attaching proposed patch to Spec file for new icon. After patch apply, there is need to add the icon from attachment (file: bacula-tray-monitor.png) to SOURCES/ directory. In my opinion better is keep desktop icon in rpm meta files, because if something is happen that icon lost from Bacula sources, then in rpm meta files the icon will be all the time. I also think that file "bacula-trymonitor.desktop" and "bacula-try-monitor.png" are something like pair, and also as pair could occur in rpm meta files. Thank you in advance for patch review and opinion. Comments are welcome.
Created attachment 1006464 [details] Screenshot from Gnome 3 with Tray Monitor icon I am also adding screenshot from that, how reverted icon to original Tray Monitor looks on desktop side.
Actually, it's better not to include the converted image as source, but to do the conversion as part of the build process (adding the necessary BuildRequires:, too). The SourceN: tag for the icon should point to the original image that you convert to PNG instead.
@Dominik. OK. Thanks for the notice. I will prepare this change in Spec file.
Created attachment 1052202 [details] Add gcc requirements and fix tray monitor patch
Created attachment 1052203 [details] Original tray monitor icon
Hello, I added conversion tray monitor icon from xpm to png format. Additionally I added gcc and gcc-c++ in BuildRequires fields.
Thanks for the patch. I've made a change, ImageMagick is pulled in only on RHEL 6+, as the graphical programs (i.e. bat) are not built on RHEL 5+. Testing the build now on all supported distributions (RHEL 5/6, Fedora 21+).
Fixed this in f23 and rawhide, don't think it's necessary to push an update just for this. I've committed the change in all branches, so whenever a new update is required the "new" (ugly) icon will be in place. http://pkgs.fedoraproject.org/cgit/bacula.git/commit/?id=e397501cfedb78a2d0065c32d36c361c12b9a890